Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758903AbcJZL0Y (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Oct 2016 07:26:24 -0400
Received: from mail-wm0-f65.google.com ([74.125.82.65]:34715 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1758727AbcJZL0U (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Oct 2016 07:26:20 -0400
MIME-Version: 1.0
In-Reply-To: <13aa20e8-2931-8817-1d07-7bda8f28fb19@redhat.com>
References: <1477304593-3453-1-git-send-email-wanpeng.li@hotmail.com>
 <20161024150323.GB2247@potion> <fa03f516-25ea-40e7-dd47-4dc9753d1b5b@redhat.com>
 <20161024152737.GB3197@potion> <CANRm+CypjCjAJPzbd7SfHVB0940sMQx7Zz_0dbn=Dg-AkHNd9A@mail.gmail.com>
 <20161025114334.GD3197@potion> <CANRm+CwSd7urOU8Crs-jCifApCf8zeDBFqWVqjRNQAD3UgA9fA@mail.gmail.com>
 <13aa20e8-2931-8817-1d07-7bda8f28fb19@redhat.com>
From: Wanpeng Li <kernellwp@gmail.com>
Date: Wed, 26 Oct 2016 19:26:18 +0800
Message-ID: <CANRm+Cw3SZc-Y8C6sc2_O2V_WbgKYXEjUChwVcAVR8FnGYsknQ@mail.gmail.com>
Subject: Re: [PATCH 6/5] KVM: x86: fix periodic lapic timer with hrtimers
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>, Yunhong Jiang <yunhong.jiang@intel.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1197
Lines: 35

2016-10-26 19:15 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>
>
> On 26/10/2016 12:23, Wanpeng Li wrote:
>>> >
>>> >         if (apic_lvtt_oneshot(apic) &&
>>> > -           ktime_after(apic->lapic_timer.target_expiration,
>>> > -                       apic->lapic_timer.timer.base->get_time())) {
>>> > +           !ktime_after(apic->lapic_timer.target_expiration,
>>> > +                        apic->lapic_timer.timer.base->get_time())) {
>>> >                 apic_timer_expired(apic);
>>> >                 return;
>>> >         }
>>> >
>>> > Paolo, can you squash that?
>> It seems that squash is impossible since the dependency of current
>> kvm/queue(KVM: x86: use ktime_get instead of seeking the
>> hrtimer_clock_base), I will send out a separate patch to fix this.
>
> It is squashed in:
>
> +       if (apic_lvtt_oneshot(apic) &&
> +           ktime_after(apic->lapic_timer.timer.base->get_time(),
> +                       apic->lapic_timer.target_expiration)) {
> +               apic_timer_expired(apic);
> +               return;
> +       }
>
> Notice that the order of the arguments is inverted (alternatively I
> could have used ktime_before).

Indeed.

Regards,
Wanpeng Li