Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754476AbcJZMQG (ORCPT ); Wed, 26 Oct 2016 08:16:06 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:36464 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753228AbcJZMQE (ORCPT ); Wed, 26 Oct 2016 08:16:04 -0400 Date: Wed, 26 Oct 2016 13:18:32 +0100 From: Lee Jones To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/15] mfd: tc3589x: improve function-level documentation Message-ID: <20161026121832.GT8574@dell> References: <1475351192-27079-1-git-send-email-Julia.Lawall@lip6.fr> <1475351192-27079-7-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1475351192-27079-7-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1386 Lines: 44 On Sat, 01 Oct 2016, Julia Lawall wrote: > Use the correct function name in one case and adjust a variable name to > that of the corresponding function parameter in another case. > > Issue detected using Coccinelle (http://coccinelle.lip6.fr/) > > Signed-off-by: Julia Lawall > > --- > drivers/mfd/tc3589x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c > index 274bf39..cc9e563 100644 > --- a/drivers/mfd/tc3589x.c > +++ b/drivers/mfd/tc3589x.c > @@ -53,7 +53,7 @@ int tc3589x_reg_read(struct tc3589x *tc3589x, u8 reg) > EXPORT_SYMBOL_GPL(tc3589x_reg_read); > > /** > - * tc3589x_reg_read() - write a single TC3589x register > + * tc3589x_reg_write() - write a single TC3589x register > * @tc3589x: Device to write to > * @reg: Register to read > * @data: Value to write > @@ -118,7 +118,7 @@ int tc3589x_block_write(struct tc3589x *tc3589x, u8 reg, u8 length, > * @tc3589x: Device to write to > * @reg: Register to write > * @mask: Mask of bits to set > - * @values: Value to set > + * @val: Value to set > */ > int tc3589x_set_bits(struct tc3589x *tc3589x, u8 reg, u8 mask, u8 val) > { > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog