Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942467AbcJZMpc (ORCPT ); Wed, 26 Oct 2016 08:45:32 -0400 Received: from mail-dm3nam03on0046.outbound.protection.outlook.com ([104.47.41.46]:6272 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935357AbcJZMpZ (ORCPT ); Wed, 26 Oct 2016 08:45:25 -0400 X-Greylist: delayed 111147 seconds by postgrey-1.27 at vger.kernel.org; Wed, 26 Oct 2016 08:45:24 EDT Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; free-electrons.com; dkim=none (message not signed) header.d=none;free-electrons.com; dmarc=bestguesspass action=none header.from=xilinx.com; From: Naga Sureshkumar Relli To: Richard Weinberger , Christoph Hellwig CC: "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "dedekind1@gmail.com" , "adrian.hunter@intel.com" , "michal.simek@xilinx.com" , "Punnaiah Choudary Kalluri" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Boris Brezillon Subject: RE: UBIFS LEB properties tree with odd addresses Thread-Topic: UBIFS LEB properties tree with odd addresses Thread-Index: AdIuhYzSHMtf8MMlQH+bJ6F6DdMcjwAPB2aAAC/Mm9A= Date: Wed, 26 Oct 2016 12:11:23 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.23.17.126] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22660.004 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(377454003)(13464003)(43544003)(189002)(199003)(106466001)(47776003)(92566002)(87936001)(7846002)(4326007)(2906002)(8676002)(2950100002)(19580405001)(23726003)(19580395003)(81166006)(81156014)(7696004)(7736002)(63266004)(11100500001)(86362001)(189998001)(5001770100001)(5660300001)(305945005)(626004)(3846002)(97756001)(102836003)(46406003)(6116002)(55846006)(8936002)(356003)(50986999)(5250100002)(8746002)(54356999)(586003)(76176999)(33656002)(50466002)(2900100001)(2920100001)(107986001)(217873001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CO1PR02MB160;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT007;1:XpNpR3tbU9MmZV3jdGDOPwwGTdqR3RvC6nyE5TsoTrUhaP+Cq1sz7snoAS4+3sihU9ItT9KeXYdLyh5x+DFOrVHbBvzk0jjs+2SweuZ5VXlj0e9ucibIu9eoEDMChqjFL6dFNYZLvdBC/VN9vKgU9Gf2IvEzLTMmqY9Us9ZJNCFsiYCV+Pvl/0ZBRdlH0ROb9l9kcTFJrb8A2IvFWJQV8tjkN6Ajobni5sW8vW+5NNhxiYn54laZ0tk68PcYKURX8Ai7uOb2ra5qFp+FaoKgR56AqR9UaJe6593Kg0lZbdwxQ8SvH3MHmqvEWfSDfwHnkjlevz2Adu7dHpGVgjYwemhmtDvZCrJzmfF+w+dS7d6n+Vkl790NQK0/+i7rBQh9GYfVrtdbubGu8pua6vDZySRrqEd3cw5blinp/XPxnXDk5ZWY8btSwr6eE4XLDV5fZcisIISwTVZOYIPiTmIszPJ4vLAYFDwms/A/5yZnq0vC3dEKusiD9YF6Gmbd9KeYALmfT9+TzOBsNE0aVgX6ObmFi5g9fuLjelGFdApbepFc0dCDZZ+CL1LcWRa2ibBGU1k9Nwr9twAS2+u+Y6CF9jMUKyJed7Xf5mfqLz9WiN/KXTo/JteWnSygdGghSjjj8ot7H7Ro3FSJN0v2mlB+8w== X-MS-Office365-Filtering-Correlation-Id: 353a61e4-699b-4afa-1e71-08d3fd993717 X-Microsoft-Exchange-Diagnostics: 1;CO1PR02MB160;2:NW7GXYFLeRlM7PrqHbmIlOjxHtEdEXg6o7gB4w7ZgSqAfdcviXDx2dYouZBIiDSwi2ME6ZkUGO/akFO0NZxXYbvQdg1Z21HQrCs9MOKbwTETKpSqZjAitS6D7a9MRcPXUXfU8TgurL3FEZTDETMeSxaX3QvXYZhhbZqFdVP+2RQaIXKKMGotGYmO9c843GcP0g8SKsGRki631TNBG2WHGA==;3:FSUELt5Ka44dARQgZ1OOwDhjjUeBjRo7c+LZV+0JL1EScsVjq1/nryAXWOejqzuM/ETAHx85ZAXtl2a/eyaQY+q7Fxl+be2sjKm0lDiaDR33QVRCnME4f7HQQlVmR4glbjLX9pabufLfJaqK5VCLokdr9s/B0nzpLg4QPk0iFD7oFbcHgE7taNr8Kf1nN35TsRgFW56+/dbh7czhIlBuBhGJkj+61qkVKDKErFQF3KwkRayD8dgKBWKZ06S0mqJddJtCybaLv2nOhInU3IYvFYQd6T83uAcCEh8dlrXCtcI=;25:jOKi6oYpA3dkzyblLPLlRuGHijE4FCvarpgN40dXzDJzbNlZiz7LXu0Ir4y7wfjzYj8U0q9wz2R4LpbtcvoDf94+aAkfT6VfkAOhU7tbyi+8qoHRh0qHRIODVwY4HISCXGQoEu0pOFrl3f8N87Ih+VjT3bkvq/jr+6c+bV2t7TkOvXoIC+2/MwaRzNs9W1E51HHTWQUM6pJlFX4H7WHSl6y8abDA0AVW0wHaOsBJaOUCIZuLfBxE0kcGZEy/ndpqkS026NybVcGD5CFLsvcTt3NE7NSqbtO/0IlpyDM+FvOkAfpNNNQL1A1GSrp0v26iFS7avsaCeOnzFMij+YRw0PYtvt8EaMWtJNpQtTVQd0TROefVrgHsiedQ1ClDTN+pCfbrgt00W9RkAqtAMyRceHpdz2hPQdrnxk3C9FHarfNXOIg7XIb55hlPbSiax6P4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CO1PR02MB160; X-Microsoft-Exchange-Diagnostics: 1;CO1PR02MB160;31:8uMhvqHu6HZhE8FKUCdOCaRWQk/ZKksKqqim2VrNlX0MbjSCMKkXCKcBP7DeSv1AQuPun/Zp0p8vMR1PmGPCPsh0oxVe1JZ80qy8H6QfpCnlJcTxo293Jfga92VeLJEsKuQvXWNWUw2TE+AX0BLUtvxWoNdYMwfEbOxxwjIWI0OBJv1s9UNWIdj7Tk+HRaj+fE/G6qalbA15Wh5P1LaTQEqbhio+/3iGNaRTcuryJ1chCCmFynXp2rxgRp9BoNjwuk3Vw7q96GCiBDAFYP0KMQ==;20:TLR/1+VkiOP8jrwDzunJOp8x5Ks6YAbeTCmqI/gZAEgC/zrKvPPZUuBblEmAd8Yvrllxg7j9NC0QabTa8/kN5NyeJ9EPHoI0LianMnHsGTCEA986Ic5M54+23G/0r3osMLFgJPFUeqjyNRfqlQQ1F5mtJ9pDYH8mPW6H0aKnZQUXzwuX20KqHXXpTmCkMz0ihNcmLPegUirHw83AQrQnpZJbODSp7ufYLiKeY98ZcqFE8bVgKG1SRCQc+C7CEGqSZiyh60RHS7vEllb38ftfuwo1JwWO0lipq/6J+36i8+P9mB1rl9tupEO8mRrGeqVU1RCJwjC8sJU97zWKgphE7TvOLGmvkH/PBBY68uxEg1x8CRhImhuIawRxmPic016y3+6lJki0kG45mbLG/XMFUyrqjamxNqyBAWXC4zFEJdA8WbWqMMjD69qpBdqY62f2n3BrHC2xezPAOuA9AytMaabwGOikFdXSGZlERlmXv9sNexhM2v4oLfNdg6GpcEeE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(258649278758335)(192813158149592)(58145275503218)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13024025)(13017025)(13018025)(8121501046)(13015025)(13023025)(5005006)(10201501046)(3002001)(6055026);SRVR:CO1PR02MB160;BCL:0;PCL:0;RULEID:;SRVR:CO1PR02MB160; X-Microsoft-Exchange-Diagnostics: 1;CO1PR02MB160;4:BjWVzF5zMxG4yQLR1D5Lh14Dl/JC8d4i1BCH7vbEgrFwepr1jKoeSRoL66QgPxW2CJF42+B9AnIEAYuNLQ+aDV1KutrA0Fndqx5gkPpQ5ZMwgPqONO0GUdSIdZOS3fXtmsSSc0LmVZvcRK0OJQ9ROAL6ftyS0f4D47NJ3nuCuxSkeuNBmSMAPpTam8tPVYmSEFjackSqPlGBZqHa/NhuBjvoJlXabq34+29dJpH85PR/bsnrybpw51faKp5UJlBKOaSILYm8csv81LDVKwrohoETGZoRXI1XC9CqrRL0UEnm2ijnlKIp6dYLMIkHdRkOcyIffoSu/IymSvVm9daZBkJQizb0dl81LpzoaAlk1VMk573ogRzEQSVpwg14VeXmr65sjpX2uGUt0Ty5C4VFuVLqu9tBGjW4aHvABlDsqvLYPS0Jhn4Gqic4AnxweI8HIWPdwwBYmxTHhoAwLzRiq6m0IG5kT+Z8sCL+fVVINwmzolgH0yWUJITzg6MkfmItsNHdeIqtU11+tCwOW7x+OP0oiaPxe3ec9SaQDXNjC47I/jfkX9erWP5SHM5ghTKq20scdQUkxSb1l4hclsCOOK9Gjhe0MtLX8EAOgRHK1WuyBmlq/4t0tlpJwlkiYVqSb8l9hTgJ5mggWW/npvzcvfxeTO2oOxRBwhnGr+nBNT6ElK1eIlai4SqdP7sJfkzU X-Forefront-PRVS: 0107098B6C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO1PR02MB160;23:p7hmLceXM2u3ltvwCUFfQW0XHSV2CKm0iGA5FMOP9t?= =?us-ascii?Q?lR2D8leMuWN/i0exwr+gLtHglVvTOrnjitoxgF49B8Q5NZ1mnBDsch28OAna?= =?us-ascii?Q?kyNyJhaaKJyA8J2DiRvfYIc0UyB5zfjWO86u7tDSKhvUIfNkpbNay6KMyXv3?= =?us-ascii?Q?pUMJWcpLqJsgpmfkRk3V/8j6/zz+sK+IvA/CVR77j0p4C2T3wXf0ye/YaUBB?= =?us-ascii?Q?qIvy4k2RupLVrjzhCZbopGn8AxZR0d6qFyPkZUxv2fqnYFVze7zq3KwXHd50?= =?us-ascii?Q?CJOwi9c6f3xypijyEiSmE284Y72aQNVzB5mScQwxJbkOKELCy9Z4PaYQlNpR?= =?us-ascii?Q?pIBCVy5Q8lqOO3+K3uPre/ETApSAtNbKuhsNQvFOKslfN5AXNwVRtBrFo0oA?= =?us-ascii?Q?g7xRJJuVOJ4we5w13H4VxI1DNniDJu6rRrQjOtzaZ9OG9vjtvflqKds9BDsd?= =?us-ascii?Q?oZRzzYtWGcjy1ZqwWjRPLzp66UaW6gPPq4oLBDx3RBzUhKjQ6n9MNB0+EpRH?= =?us-ascii?Q?BK/RdEw21PfAnUPLV2IaDFji58I+yD757DhmMzHLZvrO+k1Ql9s4WV8XcAdB?= =?us-ascii?Q?SIt97pX1Mxa0hdXSx4c7vPomL0e5F1SS9EeEHbOLhpoCdDSoviPltprK/ZQh?= =?us-ascii?Q?0vF5WPPyQyDkhyvwIBB3D/71mTFJN6Zx5XdVKEuT9TxtB9yYrlJaaXgxxYkP?= =?us-ascii?Q?r8GPahDfaaUuasjHJ34XdhJLtiZBH1uM1C/hAcrghrp/eTbBhXCKRFlLowMT?= =?us-ascii?Q?mTwneOUMqZFYjSR763Qs2Jod2kYhw4rxSO0vDO2xxHsSgxP95k+HMUHpMZLM?= =?us-ascii?Q?p65LrFtgpVhP7xn2ApitQmKwtqUp9hQ2V1IjzgB94nTm9Lcvbe6s5tXzRkuY?= =?us-ascii?Q?bvsQrEoMvfPks0k+7acFut89AhRGb0Rm63MXCoMg6/KgXDJocIrMX2Kr3ryG?= =?us-ascii?Q?LBJHW6KgL/8VVj3lbcUClQlfflutvUKgc03LFtrVpmjLlBaIjpJ7NUmboEB/?= =?us-ascii?Q?cYqvh4Mxtcju99Z3HZsGJ6jkRoS3XoHimK63mK4moGt25JjuQvB84ELOEelb?= =?us-ascii?Q?yhoy1fyDQTaba7qA4CnThy5Zo1g0MBhTR8OPo66q6c8/7izcEJsvLGnQ2AT4?= =?us-ascii?Q?sPxyJnIqXNxH9Lm5TdzwzBkZKqKrPErvgHO3tXlLhvKZLi1nzH6G33COq4Ja?= =?us-ascii?Q?k2pm+7U9g549U3uYkSw+xQ/S2QGHK9q87uGZ1lmocbox/zwDkqHmcWY8eNhn?= =?us-ascii?Q?DTQrcsuLSHafJZVPUCRn+EcO8lwNIKn/Ghi4y2HQGwYdYYPEZDYtnUvCFoQw?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CO1PR02MB160;6:MU+iIYpuNfeY++0NHBY3kkWRFnxMkCXHzghedYw221KhJ62pVGwPhNkKJyZbyZBIpffZWEM2YEaUazfJUUvllJ6dB2/FyNjdwceXTzPsspB/9TEZLHQWHIPnNkvoU2IRJav4WTZMDTNdiDLxn2iIaPNLUzX+u5957c/FyUXTWq233oXsYlA0O2L4Ib94Z848gZ40TsPplOhJmF1TWQBhzUdJzmIXranS1D7wd7OebpjWseLHCD85amTNqjXdeLppOHV3nGFu+eW8Oy8gG4TMExJO5MRuoVbE2+LAguN2Z+/7cwl60wqUiG3jv3XMaNX/B1aji0Li8W8fQJ54adsg7PcfxQJwCwAXByXjSb7nDbs=;5:W0P+2R5/NOijUfgD4M0JVwLaWr3xm3kR5StsgRUP2wVAxoMVj3/OWa1Wrkln9C9trIz0cHDNH9ovHCFN2ZdJTg/x1oSr7hWx1LgZ51ivyGfbJOPVUxRBBEw3csXtJ+tBBsFKNJoKuHx/A4cuK4nVzQ==;24:c5ci1Ua6pYHBsg/eAjnHWujuuXxQ/lUpsBRSDDnHkz9MQnJIlxbBtnxZkzjoZ1dvH9Vxig6TyoFZMv2eEkWv3+4XGe2O+Otmoa4m67qdUTA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO1PR02MB160;7:lhsT62TJ+r09QWcN5Ulh5406mdgDK3NO+YFguqDlWLQ9cgLNEZ+o06FBRP4DhTsZjHwcFZ+KF7bRv1metYUNEP3k2996hA4TTNsIFit9uanl0T/5zjE5WCHI5QpiNXLKOQaslze3fjSKQ5mKjSx2sfVZ3409Odep2uAYi0Z5BZKd3QxqtX6+r3GFmAj1Ip9fnEMp5WTIXXihePcKTgus8HhbVpydEdwATrM3QVxjsJ9dgjTDJb+3Ty8RwiZsVUXh3/hYdh5LQvpm9SQiUrsV1c5WZSLjRC8BjF4yVE4ia3Z80oDAH2rqvXVkc9VRkGdYhwNeH7ehpIWkCQJkK5rKXAbdEyhlU0NENYTFyV9zWq4=;20:Z79q/1CuBmvi/QgPlyOlz7/k8A7Nd9cz6PuD5E1Jnrayi/eGSiQVuLWZFGD205IDVQJu6rDTbOV1DxOijGwpvrPUb2jQtxv8+g4qfsWZHPaORZ+m5nOLrRI7hs6SSqmsbskyToP+q+uW+UHJu970enCQ65b6LfzPjGkYX6A/UVM= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2016 12:11:27.9051 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR02MB160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9QCjbHR031293 Content-Length: 1822 Lines: 46 Hi Richard, -----Original Message----- From: Richard Weinberger [mailto:richard@nod.at] Sent: Wednesday, October 26, 2016 2:44 AM To: Naga Sureshkumar Relli ; Christoph Hellwig Cc: dwmw2@infradead.org; computersforpeace@gmail.com; dedekind1@gmail.com; adrian.hunter@intel.com; michal.simek@xilinx.com; Punnaiah Choudary Kalluri ; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org; Boris Brezillon Subject: Re: UBIFS LEB properties tree with odd addresses Naga Sureshkumar Relli, > Even bytes i.e. 0, 2, 4,... are transmitted on Lower Data Bus > Odd bytes i.e. 1, 3, 5,.. are transmitted on Upper Data Bus. > But these details are hidden from UBI? Yes, Our controller driver will take care of these byte striping. > So for temporary hack we did the following change In fs/ubifs/lpt.c In > do_calc_lpt_geom(), added the following > + if (c->pnode_sz % 2) > + c->pnode_sz += 1; > + if (c->ltab_sz % 2) > + c->ltab_sz += 1; > > Please kindly suggest, I need your inputs, changing the pnode_sz and ltab_sz to even in lpt.c, will it impact on any others? > Hmm, the calculations in lpt.c use basic properties of the MTD (number of blocks, etc...). > Can you please double check which property causes the failure and also verify whether the MTD driver provides correct properties. i.e. page sizes, block size, number of blocks, ... Yes, only pnode_sz and ltab_sz are odd values And MTD info, here are my logs In Single Flash mode: Mtd->erasesize = 64KiB Mtd->size = 64MiB Mtd->numeraseregions = 0 Nor->pagesize = 256 In Dual parallel mode: Mtd->erasesize = 128KiB Mtd->size = 128MiB Mtd->numeraseregions = 0 Nor->pagesize = 512 Thanks, Naga Sureshkumar Relli