From: Sriram Dash <sriram.dash@nxp.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
CC: "mathias.nyman@intel.com" <mathias.nyman@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Suresh Gupta <suresh.gupta@nxp.com>,
        "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
        "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
        Rajat Srivastava <rajat.srivastava@nxp.com>,
        Rajesh Bhagat <rajesh.bhagat@nxp.com>
Subject: RE: [PATCH v2] usb: xhci: Don't drive port 2.0 reset while resuming
Thread-Topic: [PATCH v2] usb: xhci: Don't drive port 2.0 reset while resuming
Thread-Index: AQHSLqz4EbKPqEpUbUCtv7wEAa4DfaC5Ia4AgAGI2oA=
Date: Wed, 26 Oct 2016 12:34:48 +0000
Message-ID: <DB5PR0401MB192536FA8EAD160164C924BAF5AB0@DB5PR0401MB1925.eurprd04.prod.outlook.com>
References: <1477392341-5942-1-git-send-email-sriram.dash@nxp.com>
 <580F5704.7030605@linux.intel.com>
In-Reply-To: <580F5704.7030605@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2016 12:34:48.5365
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2455
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9QCowZM031447
Content-Length: 1323
Lines: 41

>From: Mathias Nyman [mailto:mathias.nyman@linux.intel.com]
>On 25.10.2016 13:45, Sriram Dash wrote:
>> For the USB3.0 controller, USB 2.0 reset not driven while port is in
>> Resume state. So, do not program the USB 2.0 reset
>> (PORTSC[PR]=1) while in Resume state.
>>
>> Signed-off-by: Rajat Srivastava <rajat.srivastava@nxp.com>
>> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
>> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
>> ---
>
>What is the actual issue that you are fixing here?

This was an erratum from Synopsis STAR: 9000962562

>Is there some device that is in resume (PLS==XDEV_RESUME) while driving reset?
>

We have not reproduced this as such.

>I just sent a pach for increasing the resume time signaling to 40ms when clearing
>the PORT_FEAT_SUSPEND.
>Does that work for you?
>
>If not, then we should look closer at why clearing the suspend does not work
>properly.
>One issue could be that ClearPortFeature PORT_FEAT_SUSPEND does not really
>read or wait for for changes in port status. It blindly sets the states based on time
>passed.
>
>Or if it's after system suspend there might be something in bus_resume that is not
>working.
>
>I don't think usb core tries to drive reset while port is still resuming
>

I am skeptical about it and hope somebody may help us on this.

>-Mathias
>