Subject: Re: [PATCH] block: flush: fix IO hang in case of flood fua req
To: Ming Lei <tom.leiming@gmail.com>, <linux-kernel@vger.kernel.org>
References: <1477472235-22845-1-git-send-email-tom.leiming@gmail.com>
CC: <linux-block@vger.kernel.org>, Christoph Hellwig <hch@infradead.org>,
        "Kent Overstreet" <kent.overstreet@gmail.com>,
        Jens Axboe <axboe@kernel.dk>
From: Jens Axboe <axboe@fb.com>
Message-ID: <a57aa5a0-f22b-dc10-07d9-47723ea6e880@fb.com>
Date: Wed, 26 Oct 2016 07:48:59 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1477472235-22845-1-git-send-email-tom.leiming@gmail.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2016 13:49:04.3936 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192
X-OriginatorOrg: fb.com
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-26_07:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 344
Lines: 10

On 10/26/2016 02:57 AM, Ming Lei wrote:
> This patch fixes one issue reported by Kent, which can
> be triggered in bcachefs over sata disk. Actually it
> is a generic issue in block flush vs. blk-tag.

Looks good to me. Had to double check we don't get there for the mq 
path, but we have our own end_io for that path. Applied.

-- 
Jens Axboe