Date: Sun, 4 May 2003 07:55:02 +0200
From: Christoph Hellwig <hch@lst.de>
To: =?iso-8859-1?Q?Ren=E9_Scharfe?= <l.s.r@web.de>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: [PATCH 2.5] [TRIVIAL] Get rid of magic numbers in drivers/block/genhd.c
Message-ID: <20030504075502.A6915@lst.de>
Mail-Followup-To: Christoph Hellwig <hch@lst.de>,
	=?iso-8859-1?Q?Ren=E9_Scharfe?= <l.s.r@web.de>,
	linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
References: <20030504000425.726daf8b.l.s.r@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.2.5i
In-Reply-To: <20030504000425.726daf8b.l.s.r@web.de>; from l.s.r@web.de on Sun, May 04, 2003 at 12:04:25AM +0200
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 976
Lines: 24

On Sun, May 04, 2003 at 12:04:25AM +0200, Ren? Scharfe wrote:
> Hi Christoph,
> 
> a few days ago you cleaned up disk_name() in fs/partitions/check.c. It
> is now guaranteed to write no more than BDEVNAME_SIZE into the provided
> buffer.
> 
> There are two buffers in drivers/block/genhd.c, that are used solely for
> calling disk_name(), and have a size of 64. The patch below replaces
> these magic numbers with BDEVNAME_SIZE.
> 
> Additionally it corrects the comment at the top of disk_name(): The md
> driver does not call that function, the genhd driver does.

Looks fine to me.

Rusty, is the trivial patch bot still active?  I haven't seen Marcelo
or Linus merging trivial patches for ages (or maybe I've missed
something?)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/