Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755418AbcJZODT (ORCPT ); Wed, 26 Oct 2016 10:03:19 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:33705 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757099AbcJZOCw (ORCPT ); Wed, 26 Oct 2016 10:02:52 -0400 Date: Wed, 26 Oct 2016 15:05:01 +0100 From: Lee Jones To: =?iso-8859-1?Q?Myl=E8ne?= Josserand Cc: vinod.koul@intel.com, maxime.ripard@free-electrons.com, wens@csie.org, mturquette@baylibre.com, sboyd@codeaurora.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, mark.rutland@arm.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, thomas.petazzoni@free-electrons.com, alexandre.belloni@free-electrons.com Subject: Re: [PATCH 05/14] mfd: sun6i-prcm: Add sun8i analog codec as subnode Message-ID: <20161026140501.GH13127@dell> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1771 Lines: 61 On Tue, 04 Oct 2016, Mylène Josserand wrote: > The sun8i audio codec is using PRCM registers to configure all the > analog part of the audio codec. It is added as a subnode of the PRCM > with his resource (offset of 0x1c0). > > Signed-off-by: Mylène Josserand > --- > drivers/mfd/sun6i-prcm.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/mfd/sun6i-prcm.c b/drivers/mfd/sun6i-prcm.c > index 011fcc5..e0c6bf5 100644 > --- a/drivers/mfd/sun6i-prcm.c > +++ b/drivers/mfd/sun6i-prcm.c > @@ -12,6 +12,8 @@ > #include > #include > > +#define SUN6I_AUDIO_CODEC_ANALOG 0x1c0 > + > struct prcm_data { > int nsubdevs; > const struct mfd_cell *subdevs; > @@ -57,6 +59,14 @@ static const struct resource sun6i_a31_apb0_rstc_res[] = { > }, > }; > > +static const struct resource sun8i_adda_res[] = { > + { > + .start = SUN6I_AUDIO_CODEC_ANALOG, > + .end = 0x1c3, This also needs defining. No magic numbers please. > + .flags = IORESOURCE_MEM, > + }, > +}; > + > static const struct mfd_cell sun6i_a31_prcm_subdevs[] = { > { > .name = "sun6i-a31-ar100-clk", > @@ -109,6 +119,12 @@ static const struct mfd_cell sun8i_a23_prcm_subdevs[] = { > .num_resources = ARRAY_SIZE(sun6i_a31_apb0_rstc_res), > .resources = sun6i_a31_apb0_rstc_res, > }, > + { > + .name = "sun8i-codec-analog", > + .of_compatible = "allwinner,sun8i-codec-analog", > + .num_resources = ARRAY_SIZE(sun8i_adda_res), > + .resources = sun8i_adda_res, > + }, > }; > > static const struct prcm_data sun6i_a31_prcm_data = { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog