Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932449AbcJZPhR (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Oct 2016 11:37:17 -0400
Received: from devils.ext.ti.com ([198.47.26.153]:50983 "EHLO
        devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754134AbcJZPhP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Oct 2016 11:37:15 -0400
Date: Wed, 26 Oct 2016 10:37:13 -0500
From: Bin Liu <b-liu@ti.com>
To: Kirill Esipov <yesipov@gmail.com>
CC: <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH v3] usb: musb: remove duplicated actions
Message-ID: <20161026153713.GL4050@uda0271908>
Mail-Followup-To: Bin Liu <b-liu@ti.com>, Kirill Esipov <yesipov@gmail.com>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        gregkh@linuxfoundation.org, sergei.shtylyov@cogentembedded.com
References: <1477491867-5253-1-git-send-email-yesipov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1477491867-5253-1-git-send-email-yesipov@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1156
Lines: 38

Hi,

On Wed, Oct 26, 2016 at 05:24:27PM +0300, Kirill Esipov wrote:
> Removing unnecessary duplicated actions that we've got while merging:
> 19915e623458 ("Merge 4.1-rc7 into usb-next")
> 
> Signed-off-by: Kirill Esipov <yesipov@gmail.com>
> ---
>  drivers/usb/musb/musb_core.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 27dadc0..2b04f07 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -2120,12 +2120,6 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
>  	if (musb->ops->ep_select)
>  		musb->io.ep_select = musb->ops->ep_select;
>  
> -	/* At least tusb6010 has its own offsets */

I prefer to keep this comment and drop the first one
"/* And override them with platform specific ops if specified. */"
as it doesn't provide any value.

> -	if (musb->ops->ep_offset)
> -		musb->io.ep_offset = musb->ops->ep_offset;
> -	if (musb->ops->ep_select)
> -		musb->io.ep_select = musb->ops->ep_select;
> -
>  	if (musb->ops->fifo_mode)
>  		fifo_mode = musb->ops->fifo_mode;
>  	else
> -- 
> 2.7.4

Thanks,
-Bin.