Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933508AbcJZPox (ORCPT ); Wed, 26 Oct 2016 11:44:53 -0400 Received: from vern.gendns.com ([206.190.152.46]:41410 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932226AbcJZPou (ORCPT ); Wed, 26 Oct 2016 11:44:50 -0400 Subject: Re: [PATCH 2/5] ARM: davinci: Don't append git rev to local version To: Sekhar Nori , Kevin Hilman References: <1477075018-20176-1-git-send-email-david@lechnology.com> <1477075018-20176-3-git-send-email-david@lechnology.com> <20f3efba-4f79-3675-d2ce-09efe90fb692@ti.com> <47ad8be9-54e0-4e0c-3ff5-31662e6ca4de@ti.com> Cc: Rob Herring , Mark Rutland , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: David Lechner Message-ID: <0fd82064-dd4a-8144-8b9d-88191407a4bc@lechnology.com> Date: Wed, 26 Oct 2016 10:44:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <47ad8be9-54e0-4e0c-3ff5-31662e6ca4de@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 41 On 10/26/2016 05:54 AM, Sekhar Nori wrote: > On Monday 24 October 2016 08:45 PM, David Lechner wrote: >> On 10/24/2016 06:35 AM, Sekhar Nori wrote: >>> On Saturday 22 October 2016 12:06 AM, David Lechner wrote: >>>> In the davinci default configuration, don't append the git revision to >>>> the local kernel version by. This seems like the more desirable default >>>> value. >>> >>> Why? To the contrary I actually quite like the fact that the git commit >>> is appended to version string. Makes it easy for me to cross-check that >>> I am booting the right image. >>> >>>> >>>> Signed-off-by: David Lechner >>> >>> Thanks, >>> Sekhar >>> >> >> Each time you make a commit, you get a new version, which installs >> another copy of the kernel modules on the device. This will fill up the >> SD card if you are making many commits. > > Right, but thats easily fixable by removing existing modules before > installing new ones. > >> Also, if someone wants to build the mainline kernel using the default >> configuration, it seems odd to have a git revision tacked on to the end >> even though you made no revisions. > > If you checkout a tag and build, then no commit information is added. > Which I guess is what most end users will do. > > I don't see this done in other defconfigs like omap2plus and multi_v7 as > well. I would like to keep it similar for davinci. > > Thanks, > Sekhar > OK, I will drop this patch.