Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933632AbcJZP4S (ORCPT ); Wed, 26 Oct 2016 11:56:18 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36884 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbcJZP4P (ORCPT ); Wed, 26 Oct 2016 11:56:15 -0400 Date: Wed, 26 Oct 2016 11:56:13 -0400 (EDT) Message-Id: <20161026.115613.576903872557968242.davem@davemloft.net> To: jkbs@redhat.com Cc: baoyou.xie@linaro.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: Re: [PATCH] rtl8xxxu: mark symbol static where possible From: David Miller In-Reply-To: <87twbz2sn8.fsf@redhat.com> References: <1477474370-31383-1-git-send-email-baoyou.xie@linaro.org> <87twbz2sn8.fsf@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Oct 2016 08:56:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1363 Lines: 32 From: Jakub Sitnicki Date: Wed, 26 Oct 2016 14:37:15 +0200 > On Wed, Oct 26, 2016 at 09:32 AM GMT, Baoyou Xie wrote: >> We get 1 warning when building kernel with W=1: >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c:1557:6: warning: no previous prototype for 'rtl8192eu_power_off' [-Wmissing-prototypes] >> >> In fact, this function is only used in the file in which it is >> declared and don't need a declaration, but can be made static. >> So this patch marks this function with 'static'. >> >> Signed-off-by: Baoyou Xie >> --- >> drivers/net/dsa/mv88e6xxx/chip.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c >> index 883fd98..4d975f0 100644 >> --- a/drivers/net/dsa/mv88e6xxx/chip.c >> +++ b/drivers/net/dsa/mv88e6xxx/chip.c >> @@ -2701,7 +2701,7 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port) >> return mv88e6xxx_port_write(chip, port, PORT_DEFAULT_VLAN, 0x0000); >> } >> >> -int mv88e6xxx_g1_set_switch_mac(struct mv88e6xxx_chip *chip, u8 *addr) >> +static int mv88e6xxx_g1_set_switch_mac(struct mv88e6xxx_chip *chip, u8 *addr) >> { >> int err; > > Probably a mix-up - your patch doesn't match the description. Agreed, please fix your subject line and commit message.