Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933296AbcJZQjX (ORCPT ); Wed, 26 Oct 2016 12:39:23 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36776 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbcJZQjV (ORCPT ); Wed, 26 Oct 2016 12:39:21 -0400 MIME-Version: 1.0 In-Reply-To: <20161026145756.21689-4-antoine.tenart@free-electrons.com> References: <20161026145756.21689-1-antoine.tenart@free-electrons.com> <20161026145756.21689-4-antoine.tenart@free-electrons.com> From: Mathieu Poirier Date: Wed, 26 Oct 2016 10:39:16 -0600 Message-ID: Subject: Re: [RFC PATCH 3/5] w1: report errors returned by w1_family_notify To: Antoine Tenart Cc: Maxime Ripard , pantelis.antoniou@konsulko.com, Mark Rutland , sboyd@codeaurora.org, Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 32 On 26 October 2016 at 08:57, Antoine Tenart wrote: GKH won't accept an empty commit log. > Signed-off-by: Antoine Tenart > --- > drivers/w1/w1.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index bb34362e930a..80d0cc4e6e7f 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/w1.c > @@ -702,7 +702,9 @@ static int __w1_attach_slave_device(struct w1_slave *sl) > dev_name(&sl->dev), err); > return err; > } > - w1_family_notify(BUS_NOTIFY_ADD_DEVICE, sl); > + err = w1_family_notify(BUS_NOTIFY_ADD_DEVICE, sl); > + if (err) > + return err; > > dev_set_uevent_suppress(&sl->dev, false); > kobject_uevent(&sl->dev.kobj, KOBJ_ADD); > -- > 2.10.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html