Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755077AbcJZT7G (ORCPT ); Wed, 26 Oct 2016 15:59:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38228 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754465AbcJZT7E (ORCPT ); Wed, 26 Oct 2016 15:59:04 -0400 Date: Wed, 26 Oct 2016 21:59:00 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, yang.zhang.wz@gmail.com, feng.wu@intel.com, mst@redhat.com Subject: Re: [PATCH 2/5] KVM: x86: do not scan IRR twice on APICv vmentry Message-ID: <20161026195900.GC4212@potion> References: <1476469291-5039-1-git-send-email-pbonzini@redhat.com> <1476469291-5039-3-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1476469291-5039-3-git-send-email-pbonzini@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 26 Oct 2016 19:59:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 389 Lines: 10 2016-10-14 20:21+0200, Paolo Bonzini: > Calling apic_find_highest_irr results in IRR being scanned twice, > once in vmx_sync_pir_from_irr and once in apic_search_irr. Change > sync_pir_from_irr to do the RVI write and kvm_apic_update_irr to > compute the new RVI on the fly. > > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Radim Krčmář