MIME-Version: 1.0
In-Reply-To: <20161026085759.3875472-1-arnd@arndb.de>
References: <20161026085759.3875472-1-arnd@arndb.de>
From: Sean Paul <seanpaul@chromium.org>
Date: Wed, 26 Oct 2016 15:59:32 -0400
Message-ID: <CAOw6vb+JHEAT4ZfrYx9BXyuz3gC9FRPoEw8YVyXEfgqTf0g=kg@mail.gmail.com>
Subject: Re: [PATCH] drm: mark drm_of_component_match_add dummy inline
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Airlie <airlied@linux.ie>, Jyri Sarha <jsarha@ti.com>,
        Daniel Kurtz <djkurtz@chromium.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1640
Lines: 44

On Wed, Oct 26, 2016 at 4:57 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added drm_of_component_match_add helper is defined as
> 'static' in a header when CONFIG_OF is disabled, causing a warning
> each time the header is included:
>
> In file included from /git/arm-soc/drivers/gpu/drm/bridge/dw-hdmi.c:23:0:
> include/drm/drm_of.h:33:13: error: 'drm_of_component_match_add' defined but not used [-Werror=unused-function]
>
> This marks it 'inline' like the other such helpers in this file.
>
> Fixes: 97ac0e47aed5 ("drm: convert DT component matching to component_match_add_release()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to drm-misc, thanks

Sean

> ---
>  include/drm/drm_of.h | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h
> index d6b4c5587bbe..26a64805cc15 100644
> --- a/include/drm/drm_of.h
> +++ b/include/drm/drm_of.h
> @@ -30,10 +30,11 @@ static inline uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>         return 0;
>  }
>
> -static void drm_of_component_match_add(struct device *master,
> -                                      struct component_match **matchptr,
> -                                      int (*compare)(struct device *, void *),
> -                                      struct device_node *node)
> +static inline void
> +drm_of_component_match_add(struct device *master,
> +                          struct component_match **matchptr,
> +                          int (*compare)(struct device *, void *),
> +                          struct device_node *node)
>  {
>  }
>
> --
> 2.9.0
>