Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933893AbcJZVre (ORCPT ); Wed, 26 Oct 2016 17:47:34 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:41912 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932653AbcJZVrb (ORCPT ); Wed, 26 Oct 2016 17:47:31 -0400 Date: Wed, 26 Oct 2016 23:43:24 +0200 (CEST) From: Thomas Gleixner To: Darren Hart cc: "Tirdea, Irina" , "linux-clk@vger.kernel.org" , "x86@kernel.org" , Stephen Boyd , Ingo Molnar , Michael Turquette , "H. Peter Anvin" , "alsa-devel@alsa-project.org" , Mark Brown , Takashi Iwai , "Bossart, Pierre-louis" , LKML , Pierre-Louis Bossart Subject: Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks In-Reply-To: <20161026213323.GB23374@f23x64.localdomain> Message-ID: References: <1476735320-4315-1-git-send-email-irina.tirdea@intel.com> <20161021045932.GA90338@f23x64.localdomain> <1F3AC3675D538145B1661F571FE1805F2F387575@irsmsx105.ger.corp.intel.com> <20161026213323.GB23374@f23x64.localdomain> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 35 On Wed, 26 Oct 2016, Darren Hart wrote: > On Mon, Oct 24, 2016 at 01:38:54PM +0000, Tirdea, Irina wrote: > > intel_pmc_* drivers or is it enough to move it as a standalone driver for now? > > If the functionality is substantially different, then I don't see a > compelling, and certainly not an immediate, need to merge them. Assume > for now they are to remain as separate drivers. I suggest keeping the > existing name for now as well. Let's just complete the move with as > little user-visible changes as possible. > > The placement of the header file is a bit tricky as it is being used in > drivers/clk/x86 in addition to the pmc_atom driver in > drivers/platform/x86. > > The best existing location would appear to be include/platform_data/ > > Thomas, is that acceptable to you? Yes > arch/x86/platform/atom/pmc_atom.c -> drivers/platform/x86 > arch/x86/include/asm/pmc_atom.h -> include/platform_data/ > > If there are enough of these, it might make sense to create: > > include/platform/x86/ > > but I suggest we start with minimal change. No. Make that x86 directory right away. include/platform_data is already a maze of 224 files. Start structuring it now. Thanks, tglx