Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934966AbcJ0ABM (ORCPT ); Wed, 26 Oct 2016 20:01:12 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:56989 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933208AbcJ0AA5 (ORCPT ); Wed, 26 Oct 2016 20:00:57 -0400 Subject: Re: bio linked list corruption. To: Dave Jones , Chris Mason , "Linus Torvalds" , Andy Lutomirski , Andy Lutomirski , Al Viro , Josef Bacik , David Sterba , linux-btrfs , Linux Kernel , Dave Chinner References: <488f9edc-6a1c-2c68-0d33-d3aa32ece9a4@fb.com> <20161026224025.mou27kki4bslftli@codemonkey.org.uk> <2bdc068d-afd5-7a78-f334-26970c91aaca@fb.com> <203e0319-bc9b-245c-e162-709267540d22@fb.com> <20161026233808.GC15247@clm-mbp.thefacebook.com> <20161026234751.e66xyzjiwifvbuha@codemonkey.org.uk> From: Jens Axboe Message-ID: Date: Wed, 26 Oct 2016 18:00:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161026234751.e66xyzjiwifvbuha@codemonkey.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: BLUPR13CA0050.namprd13.prod.outlook.com (10.160.82.21) To CY4PR15MB1192.namprd15.prod.outlook.com (10.172.177.14) X-MS-Office365-Filtering-Correlation-Id: 0f1a969b-da22-4b0d-1776-08d3fdfc4b8b X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;2:wyvS4RhhP+JrAsViFjBWbpiRRAO1yC/Z7uB2ZDaOlIoZ7nMAxFyOLaOfp+cNnyliYZIVm71ngnPFHBqM6nFw7BGmCk/fdbyEHq/tE8GN1yLFMzYIJzhHC0JDqcjbfNnXgwWuP3Wr6scy+yoUCJv70TiUUjMeravyrsvZKmdpciNdW9rhD+ln/XPjWa2DYDTYxMaNHNm2KaeyYODzxF8xow==;3:wTs/XEmchOXVnrMtPjXMWPtTnXZOsJNUc4GMw4LzRD0i8SFYIpMyqxo0OJeWNSWq0tIgfI9tW4HE5nTTsPPQiQ2tjurVAO89H7TpQfiL7041RacXZ5+DDw8yfj1VhTAR1UJfldcJErGhPV5Yf5B6ng== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;25:gRaQT73raKmldRLB3My4GD/pjB10RpGkMOt5FMiFSNs/glwSqQbc/o0xE91J9n3GScsiHhrpJO8/dFTjcF9OlWiCNYviOWio+RpSSeILCLY5NWw30njC4CyMrX32TKiSh1WII1fQIen09f9wugmewl839A3eheWRFqyY+BntLzsq5ELacvXX2DVryFacmAQnn+bQafXrwOaILSz0fQnwUPeyJoF9Hl80DXmFoV8Z40VFiwsC7mXBLZUPSHdx3jyILPFCTGVy5jRJwGSFjvooDmLf9yRYQu/aGMCLzfs25Z2b5l9kLOfosMjprmgUFEc8X6OLP0oqFYfZ3w1jsg1Alol5ElhFi9aw0PNaLMo9NZf6LAZ92xy+Vqjh4G32imNekz0n25PMwoQcjgw75a8udHsTK7ZJ4Jyx9uxPl71V89lk0I7GjBw30xLw8HgYfV0TkAjxza8BUiVnqfM7E+igd00P1dtpBWHXfzx+bGsNH3P7N6zapPpbVVQlLxpmndeOR0l2eB4bcS1agARLsvMWxiuv/txysNdfgcn79SIxcIRf8gp9ZaGoKy9eOnd4WBppEfRd+OhhakOOqvpjmVWLGiOCS4AcMEPqNHXYr1wSc9AyzE4aS9Zz10w4upDBHyjl8QJ2aphXSGK+TXaL+km9+s9OFYfDXw7Mvv6UlRF0oW3NkNgmlB5RHuVifpmAAfFQMLZ+1aM1GQUza1em2Cw8aQUGXy6Z/JnDnskPivZ9RynnT0SetqFkGv45bg3NuKSi X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;31:AkNK+dgwR3nJtQZHPrTJEhah6+WTPSICd8bdcxM/4PjxaB/37giyhq47cNwBhbeGMRkEiSoOSYiJ+Iqoh2ySWO+NmQQW+vyJtH7LdeQ64cOWG1eJSoA2ERXz/HMu1Rh0aUtnKoYlFmI9RdOBTCEvvJwBhjS+VL1mJHg6YIL1BxOxD8q01zDWca9cGSjzS1VEe6vv8ZQIs0rD6O62c2jdTqdVVK/eg+BO6w00RbxlD6L7R+ubBF3f5sckfXmeLpbYW9u0LwMFaVdaANzaaWQ30g==;20:nuXVnbMYBqOLSxdtex6CT/jkmZ1UQ3PphdMRot51Q0kCGo4G1RyQD7Ge5Co8/ujPIEYxruSUEoQOJTJOAetcyv3TW7DuDGcRqVHqpgCZ5UQtQ0Zsqf47/NxUGV3UuiqFirvEF4eUj7HZ8J8OZrlxsBuc/M7Cv2XItsVX1HNknS8=;4:ONJd5qiiGFQeSLM/GOJNLo0YLn9j4ci3I2DMPcXsm6eA/k7W5gNVIvCEHlggohMOlXbtC5OEnN4ED9OGyYvHhome43sXQ7XcKI2kRzwpiSSs5mOId3ixxlVEEvFJKSEeAIGzpZeyITZfccc0O2XAwyAbeehFGR+12zh9Ij1zC+SsYfqrm0eoRhq3m51qz7xwiqvss5ku5PPQEC7Qj12u4ZwFlyfG5wKCwLILnQXGDFDoQTTc7d1lBhEhvh8h2DcGjTUA70C/YKLePHweNw1ynaLhsu88ocA9S1xbSDNk9r8z9C9qDy6COd22SqO6tBNQNT2yPnc3bdyOtHUV+CEktlYJxNEI+2M0FFzn1CJlfUkaDU/b3NcnsZxsjA0nybLgP+YZp+tCyZMv2AWPBjnyqQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:CY4PR15MB1192;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Forefront-PRVS: 0108A997B2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(199003)(189002)(377454003)(24454002)(105586002)(31696002)(50466002)(101416001)(19580395003)(68736007)(97736004)(189998001)(4001350100001)(86362001)(107886002)(586003)(3480700004)(5001770100001)(64126003)(230700001)(36756003)(6666003)(2906002)(77096005)(65956001)(65806001)(93886004)(31686004)(65826007)(117156001)(5660300001)(6116002)(66066001)(33646002)(7736002)(76176999)(3846002)(305945005)(23746002)(83506001)(81156014)(47776003)(8676002)(81166006)(2950100002)(50986999)(54356999)(92566002)(42186005)(7846002)(106356001)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1192;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1192;23:jWuWICHRBECgrG0uUWkoIQqAMYccR1XAhbwmn?= =?Windows-1252?Q?ia3KB8JzYZHk7aCz9lpvZGsb6aAfsFqx3BUyrgNf+5cxXfaAxbaY0o0R?= =?Windows-1252?Q?z2BdAQXBVCCyay+Oc9TO47nuhL+uZeqi2Q4QZwvs/OdIVmN8nGYzQ9KF?= =?Windows-1252?Q?u+aqZpO1eBMhIe4I5t7Q5HjzlmCEFH7baeG8Ce7VBiBK7NrqQxEjgdve?= =?Windows-1252?Q?IExlTWb3NwlOkGtU21IcvMuVGNzW7MDVUhLoZ35YEB1R19+tyfSe5ftn?= =?Windows-1252?Q?cibcM9QuPZ9aj8kUVhkOK6BAO5XC2B9sPNGIQrsnJnNiYzgjhjxLQJtx?= =?Windows-1252?Q?5ZSQLuNBOiRgsfnvzEHVJi7o5zrFfcFdpom5d4852WlOuQB5/PjGbtsG?= =?Windows-1252?Q?t2F+/DnAkHH2xtcRWUH7aslu4Co3PFQTOjvTgU+3T8kou9pLOHQXY+q9?= =?Windows-1252?Q?eYvhFL3L5TUkG3rRS0JUXw/Z2rUD7LyNP+Ki+yk9x6OPluY03S1p4VWD?= =?Windows-1252?Q?PjzB5qTy4tPcn+rqUteauMF8xP0n1r+Q230LfJxU/0riMIbb4V0sG3YG?= =?Windows-1252?Q?A9HNdEh/nQs8Ful0AXPtO2O0Sg9TQ5iDLA19bsVdQY+wVdT51y5OklO1?= =?Windows-1252?Q?NyzHOSCa7+xcyseS2OFQcM4CestGVfBIOoCBM8cnz4ae3YM/xA1NI8Oo?= =?Windows-1252?Q?Hl0F1iGLpbQdhtjPPi0heITvSYyqL6SkY69LHsIvQwShFchieNugUVcU?= =?Windows-1252?Q?HnpNLQy5faQLje0Q8z4CH3i8U4PW3cz1l0GBbqhV4DF5jaC9B04SVZYx?= =?Windows-1252?Q?O1OfcMXR0Nyz/LiGEiawPQoFVtR7Fv8dAyvkzrD55DbZs+V7kKrp25sr?= =?Windows-1252?Q?TtiZjhxYX/DIUifwg0RKnxiychja+H9HyKelqfo0nuktIslH02xa6CzG?= =?Windows-1252?Q?lTvjCFzqhtKrETSUPPbLRNYQWj2X5U2IxFt9Pywe8amaXOZw2OZ9Mpzu?= =?Windows-1252?Q?S5X+CFNeOdy9Tw21uCU1GDNgCdSPZcI0tDSgGRyieyS1tQIV/pJZrH2G?= =?Windows-1252?Q?lbdLCqEoNlYFACRsiwX3nwywYnjpSLUndtVEQ+tIjMYFdOAV6ss6qlDm?= =?Windows-1252?Q?BSgB12EVPpL7GuHwayywUpREtqKNeRZAtT/CbhJKdIRY91KTIpaq40rS?= =?Windows-1252?Q?4SPYBqGKupLRRUCpm5cZHQGIBSnbi0AJ7Dz6eKKub4Ng3g+KLujZpP4X?= =?Windows-1252?Q?UIdj7Qev+BXduixaULOlMH7aUspmpVlUi+LhGTthJ3uvTjhFFIJ8TvyB?= =?Windows-1252?Q?8U0pffFvLdZL3kJ4NtL+GvDxeADCA/LIsT8jzisyoJbczeNZj9xru7Rb?= =?Windows-1252?Q?bxLIW0GaePN961haBdz6kk9BbAdE7xM1Al4cZXU/b55EE7tJgbCAe41O?= =?Windows-1252?Q?FV2+/4oxmTgPiFMjW9ozox7hrMzRQB7lX99x+9Zl2SDJNfe4aqDp8oyx?= =?Windows-1252?Q?JXL6DhztwbrsH8dRHp9otKL77zr?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;6:R3HLXVYZENrdkgf8T2RI7Xveuw/BYomj6KdgS/qVO5nfncqmvnmUKaAvlBLkydXxWREokksbGh8/WzxrTSeEBphzC4jg055B8kKWu+u9wWT/PG7Yg2Rw/qpm+VVXkx7yy/kXHQxdRLRUxeQXjffRGumgTe4JBjB2AmqpZm+6uIMeA55ObSA7uL3KWJk2X2mZrheLZSmOOXuEDcMBo8bhxTdwFGFg922AwnmF+cBX/h4YabTwEkoCDCtqbzZ0tiP43cXz1DxlZLFkIkicEUq3K41r3Xfy+SMSxqi+xK65nv0QGxlmr0HOaLZz1QbSDhNp;5:Wpp7gfBWK3CGdQc6fKTPOcb1Ur5vZskfRsza5KCIaqzt2wU5cU9LXJadK4anS3OklZ7yU1qoi/LHVfMBEEW8Ewy1NMSQm5lTWwvub0bHtNhHYNvXoCoIQk27ttYtsyFe80AOYrmPIptKQpya8/cgtg==;24:foHIr/sJ0OTqfVUfugDbTfJ4s/t1mJ+h5rh9eBTjnzduElsLTwaTg6y2WGv76iSA34BwABqbCXZpVTBX5pPyG1W+d+8RAg412YHKUJD/SNU=;7:KVnINQ/dAfYSoWLFz3PH+Pn6T8fzYSVsmIsuP0RwzbjBql3WmuZKA0ccuaoO7yuB7IK2WvMjM5rojiY0mCC5LXFH74lJ6MWzr4iHJcMHOxkOYFtToqNTa7cOgGu7CjsBf4+ElzJDk6OISOjk7Yqp05pjbL9xZlACMRUdB6BoVwYGweOYMK/fmRBWUY5MA5PgDeoc2ZoxNK/TMs/l+D30kUlBfK5xqsBwhmsIp1aKKvY2NpRExpW9VUBzHkbZFYz+ErjWvNnALXESk0DEjOg027lPq0hTxKinoo71gDBuCx6Ll9EcxSwogibpBRdKCnFVoKrm6KHD9RnZGvXgfxqZN1Zc3i8sVb8CThmszT7vd7Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;20:n50NYOEDIdJAXL0zcAtXY/KWGAbaJUIDpejpnyBtRbGOzP50+dc2TPaQ8GKp/u4HxEVCaxHvDlPCzYwXFSWt7aTfDy/pwkqbXdhfAgeNIRlztl1Z/NopO+1ASX5fSImjYgsm1iVSZYPOCzkt0fHue2mBZLssAxN8yIe/0wwBoPA= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2016 00:00:40.1300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-26_15:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 758 Lines: 25 On 10/26/2016 05:47 PM, Dave Jones wrote: > On Wed, Oct 26, 2016 at 07:38:08PM -0400, Chris Mason wrote: > > > >- hctx->queued++; > > >- data->hctx = hctx; > > >- data->ctx = ctx; > > >+ data->hctx = alloc_data.hctx; > > >+ data->ctx = alloc_data.ctx; > > >+ data->hctx->queued++; > > > return rq; > > > } > > > > This made it through an entire dbench 2048 run on btrfs. My script has > > it running in a loop, but this is farther than I've gotten before. > > Looking great so far. > > Fixed the splat during boot for me too. > Now the fun part, let's see if it fixed the 'weird shit' that Trinity > was stumbling on. Let's let the testing simmer overnight, then I'll turn this into a real patch tomorrow and get it submitted. -- Jens Axboe