Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754604AbcJ0GXf (ORCPT ); Thu, 27 Oct 2016 02:23:35 -0400 Received: from mail-vk0-f52.google.com ([209.85.213.52]:34931 "EHLO mail-vk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbcJ0GXc (ORCPT ); Thu, 27 Oct 2016 02:23:32 -0400 MIME-Version: 1.0 In-Reply-To: <20161027060546.GA3617@leon.nu> References: <1477396919-27669-1-git-send-email-binoy.jayan@linaro.org> <1477396919-27669-9-git-send-email-binoy.jayan@linaro.org> <20161025122609.GQ25013@leon.nu> <20161027060546.GA3617@leon.nu> From: Binoy Jayan Date: Thu, 27 Oct 2016 11:53:30 +0530 Message-ID: Subject: Re: [PATCH v2 8/8] IB/mlx5: Add helper mlx5_ib_post_send_wait To: Leon Romanovsky Cc: Doug Ledford , Sean Hefty , Hal Rosenstock , Arnd Bergmann , linux-rdma@vger.kernel.org, Linux kernel mailing list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 24 On 27 October 2016 at 11:35, Leon Romanovsky wrote: > On Tue, Oct 25, 2016 at 06:46:58PM +0530, Binoy Jayan wrote: >> On 25 October 2016 at 17:56, Leon Romanovsky wrote: >> > On Tue, Oct 25, 2016 at 05:31:59PM +0530, Binoy Jayan wrote: >> >> > In case of success (err == 0), you will call to unmap_dma instead of >> > normal flow. >> > >> > NAK, >> > Leon Romanovsky >> >> Hi Loen, >> >> Even in the original code, the regular flow seems to reach 'unmap_dma' after >> returning from 'wait_for_completion'(). > > In original flow, the code executed assignments to mr->mmkey. In you > code, it is skipped. > Yes you are right, I just noted it. My bad. I've changed it now. Thanks, Binoy