Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261326AbTEDSYW (ORCPT ); Sun, 4 May 2003 14:24:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261339AbTEDSYW (ORCPT ); Sun, 4 May 2003 14:24:22 -0400 Received: from sol.cc.u-szeged.hu ([160.114.8.24]:34693 "EHLO sol.cc.u-szeged.hu") by vger.kernel.org with ESMTP id S261326AbTEDSYV (ORCPT ); Sun, 4 May 2003 14:24:21 -0400 Date: Sun, 4 May 2003 20:36:48 +0200 (CEST) From: Geller Sandor To: Chuck Ebbert <76306.1226@compuserve.com> cc: linux-kernel Subject: Re: compile fix for IBM PCI hotplug driver (linux 2.4.21rc1-ac4) In-Reply-To: <200305041040_MC3-1-3755-1BD@compuserve.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 30 On Sun, 4 May 2003, Chuck Ebbert wrote: > > > if(create_file_name (slot_cur, buf)==0) > > Wow. Three whitespace violations on one line: > > - no space after 'if' > - space between function and args > - no space around '==' operator > > I know you didn't write that, I just had to comment because it almost > hurts to look at it... > > >- snprintf (slot_cur->hotplug_slot->name, 30, "%s", ); > >+ snprintf (slot_cur->hotplug_slot->name, 30, "%s" ); > > > Doesn't this need a fourth parameter here instead of just > removing the comma? Yes, Andreas Haumer fixed the compile problems correctly in his post. Geller Sandor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/