Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935891AbcJ0Nu0 (ORCPT ); Thu, 27 Oct 2016 09:50:26 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:36819 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935723AbcJ0NuY (ORCPT ); Thu, 27 Oct 2016 09:50:24 -0400 Subject: Re: [RFC PATCH 02/13] of: Remove excessive printks to reduce clutter Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=utf-8 From: Pantelis Antoniou In-Reply-To: Date: Thu, 27 Oct 2016 16:51:01 +0300 Cc: Frank Rowand , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Message-Id: <022037BA-60BC-4A85-B51A-04F96E854952@konsulko.com> References: <1477429146-27039-1-git-send-email-frowand.list@gmail.com> <1477429146-27039-3-git-send-email-frowand.list@gmail.com> To: Rob Herring X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9RDobKu006898 Content-Length: 1235 Lines: 41 Hi Rob, Frank, > On Oct 27, 2016, at 15:21 , Rob Herring wrote: > > On Tue, Oct 25, 2016 at 3:58 PM, wrote: >> From: Frank Rowand > > Maybe some should be debug? > Yes, please do not get rid of them completely. Leave them at least as debug level so that if there’s a problem there’s a way to figure out why something happened. >> Signed-off-by: Frank Rowand >> --- >> drivers/of/resolver.c | 28 ---------------------------- >> 1 file changed, 28 deletions(-) >> >> diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c >> index 4ff0220d7aa2..93a7ca0bf98c 100644 >> --- a/drivers/of/resolver.c >> +++ b/drivers/of/resolver.c >> @@ -116,8 +116,6 @@ static int __of_adjust_phandle_ref(struct device_node *node, >> >> propval = kmalloc(rprop->length, GFP_KERNEL); >> if (!propval) { >> - pr_err("%s: Could not copy value of '%s'\n", >> - __func__, rprop->name); >> return -ENOMEM; >> } > > I would remove the brackets in this patch rather than separately. > >> memcpy(propval, rprop->value, rprop->length); Regards — Pantelis