Date: Thu, 27 Oct 2016 14:54:41 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>,
        Jiri Kosina <jikos@kernel.org>, Greg KH <greg@kroah.com>,
        Hannes Reinecke <hare@suse.com>, Steven Rostedt <rostedt@goodmis.org>,
        Arnd Bergmann <arnd@arndb.de>, Tom Gundersen <teg@jklm.no>,
        Josh Triplett <josh@joshtriplett.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC v1 05/14] bus1: util - pool utility library
Message-ID: <20161027125441.GE3175@twins.programming.kicks-ass.net>
References: <20161026191810.12275-1-dh.herrmann@gmail.com>
 <20161026191810.12275-6-dh.herrmann@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161026191810.12275-6-dh.herrmann@gmail.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 466
Lines: 21

On Wed, Oct 26, 2016 at 09:18:01PM +0200, David Herrmann wrote:
> +static struct bus1_pool_slice *
> +bus1_pool_slice_free(struct bus1_pool_slice *slice)
> +{
> +	if (!slice)
> +		return NULL;
> +
> +	kfree(slice);
> +
> +	return NULL;
> +}

The return value is never used. Which reduces the entire thing to:

	kfree(slice);

since kfree() already accepts a NULL.

> +		bus1_pool_slice_free(slice);
> +			bus1_pool_slice_free(slice);
> +			bus1_pool_slice_free(ps);