Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936506AbcJ0NyL (ORCPT ); Thu, 27 Oct 2016 09:54:11 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:49913 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934834AbcJ0NyG (ORCPT ); Thu, 27 Oct 2016 09:54:06 -0400 Subject: Re: [PATCH 4/5] ARM: davinci: enable LEDs default-on trigger in default config To: David Lechner , Kevin Hilman References: <1477075018-20176-1-git-send-email-david@lechnology.com> <1477075018-20176-5-git-send-email-david@lechnology.com> CC: Rob Herring , Mark Rutland , Russell King , , , From: Sekhar Nori Message-ID: <669b14c2-7f62-35bc-c8a3-6dde05a99fb1@ti.com> Date: Thu, 27 Oct 2016 16:59:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477075018-20176-5-git-send-email-david@lechnology.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 929 Lines: 25 On Saturday 22 October 2016 12:06 AM, David Lechner wrote: > The LEDs default-on trigger is nice to have. For example, it can be used > to configure a LED as a power indicator. > > Signed-off-by: David Lechner > --- > arch/arm/configs/davinci_all_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig > index 9d7f0bc..e380743 100644 > --- a/arch/arm/configs/davinci_all_defconfig > +++ b/arch/arm/configs/davinci_all_defconfig > @@ -181,6 +181,7 @@ CONFIG_LEDS_GPIO=m > CONFIG_LEDS_TRIGGERS=y > CONFIG_LEDS_TRIGGER_TIMER=m > CONFIG_LEDS_TRIGGER_HEARTBEAT=m > +CONFIG_LEDS_TRIGGER_DEFAULT_ON=y Can this be module like rest of the triggers? It will come on later, but not sure if you care about the difference that much. Having it a module will be better for those boards that don't need it. Thanks, Sekhar