Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964848AbcJ0N5l (ORCPT ); Thu, 27 Oct 2016 09:57:41 -0400 Received: from slow1-d.mail.gandi.net ([217.70.178.86]:59489 "EHLO slow1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934502AbcJ0N5i (ORCPT ); Thu, 27 Oct 2016 09:57:38 -0400 X-Originating-IP: 83.155.44.161 Message-ID: <1477564370.2458.8.camel@hadess.net> Subject: Re: [PATCH 1/4] Input: goodix - Restructure cfg checksum function From: Bastien Nocera To: Franklin S Cooper Jr , dmitry.torokhov@gmail.com, robh+dt@kernel.org, octavian.purdila@intel.com, irina.tirdea@intel.com, merker@debian.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, nsekhar@ti.com, nm@ti.com Date: Thu, 27 Oct 2016 12:32:50 +0200 In-Reply-To: <20161020195917.20051-2-fcooper@ti.com> References: <20161020195917.20051-1-fcooper@ti.com> <20161020195917.20051-2-fcooper@ti.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.1 (3.22.1-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 556 Lines: 15 On Thu, 2016-10-20 at 14:59 -0500, Franklin S Cooper Jr wrote: > Split generation of checksum into is own function. Currently it is used "its own". > only to determine if the checksum for the user provided configuration file > is valid or not. However, support to dynamically alter the configuration > file will be supported and needs a way to calculate the updated file's > checksum. Therefore, by splitting calculating checksum into its own > function the code can be reused. > After the fixup above: Reviewed-by: Bastien Nocera