From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Guenter Roeck <linux@roeck-us.net>
CC: LINUX-KERNEL <linux-kernel@vger.kernel.org>,
        LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>,
        Wim Van Sebroeck <wim@iguana.be>,
        DEVICETREE <devicetree@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        LINUX-INPUT <linux-input@vger.kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>
Subject: RE: [PATCH V2 08/10] watchdog: da9062/61: watchdog driver
Thread-Topic: [PATCH V2 08/10] watchdog: da9062/61: watchdog driver
Thread-Index: AQHSL60d9p917Tk4Pk2E++bByg86HqC7BgYAgADvu0A=
Date: Thu, 27 Oct 2016 13:10:24 +0000
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CCE6655@SW-EX-MBX02.diasemi.com>
References: <cover.1477501000.git.stwiss.opensource@diasemi.com>
 <ecd0c36a9e1766e327b54afa6bf986e64890b881.1477501000.git.stwiss.opensource@diasemi.com>
 <20161026185926.GA16142@roeck-us.net>
In-Reply-To: <20161026185926.GA16142@roeck-us.net>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-kse-attachmentfiltering-interceptor-info: protection disabled
x-kse-serverinfo: sw-ex-cashub02.diasemi.com, 9
x-kse-antivirus-interceptor-info: scan successful
x-kse-antivirus-info: Clean, bases: 27/10/2016 05:19:00
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1365
Lines: 47

On 26 October 2016 19:59 Guenter Roeck wrote:

> On Wed, Oct 26, 2016 at 05:56:39PM +0100, Steve Twiss wrote:
> > From: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > +static const struct of_device_id da9062_compatible_id_table[] = {
> > +	{ .compatible = "dlg,da9062-watchdog", .data = &da9062_watchdog_info },
> > +	{ },
> > +};
> > +
> >  static int da9062_wdt_probe(struct platform_device *pdev)
> >  {
> >  	int ret;
> >  	struct da9062 *chip;
> >  	struct da9062_watchdog *wdt;
> > +	const struct of_device_id *match;
> >
> >  	chip = dev_get_drvdata(pdev->dev.parent);
> >  	if (!chip)
> >  		return -EINVAL;
> >
> > +	match = of_match_node(da9062_compatible_id_table,
> > +			      pdev->dev.of_node);
> > +	if (!match)
> > +		return -ENXIO;
> > +
> >  	wdt = devm_kzalloc(&pdev->dev, sizeof(*wdt), GFP_KERNEL);
> >  	if (!wdt)
> >  		return -ENOMEM;
> >
> >  	wdt->hw = chip;
> >
> > -	wdt->wdtdev.info = &da9062_watchdog_info;
> > +	wdt->wdtdev.info = (const struct watchdog_info *)match->data;
> 
> I don't see why you would need match->data or of_match_node above.

Hi Guenter,

True. I do not need to do any matching on the table any more if the assumption is
to use a fall-back compatible string for DA9061 devices (to use the da9062 device
driver).

I can erase most of that content. Including the .data = &da9062_watchdog_info.

Regards,
Steve