Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942436AbcJ0OP4 (ORCPT ); Thu, 27 Oct 2016 10:15:56 -0400 Received: from mail-qk0-f173.google.com ([209.85.220.173]:36835 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942562AbcJ0OPs (ORCPT ); Thu, 27 Oct 2016 10:15:48 -0400 MIME-Version: 1.0 In-Reply-To: References: <20161026210812.18131-1-ahaslam@baylibre.com> From: Axel Haslam Date: Thu, 27 Oct 2016 15:08:36 +0200 Message-ID: Subject: Re: [PATCH] USB: OHCI: make ohci-da8xx a separate driver To: David Lechner Cc: Alan Stern , sergei.shtylyov@cogentembedded.com, Sekhar Nori , Kevin Hilman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 492 Lines: 18 On Thu, Oct 27, 2016 at 2:58 AM, David Lechner wrote: > On 10/26/2016 04:08 PM, ahaslam@baylibre.com wrote: > >> +module_exit(ohci_da8xx_exit); >> +MODULE_DESCRIPTION(DRIVER_DESC); >> +MODULE_LICENSE("GPL"); >> MODULE_ALIAS("platform:ohci"); > > > The "ohci" in MODULE_ALIAS() should also be replaced with hcd_name. i dont see any other module int the whole kernel that is using a const char here, ill just change back to #define the name and use that instead. > >