Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755814AbcJ0Ots (ORCPT ); Thu, 27 Oct 2016 10:49:48 -0400 Received: from mail.kernel.org ([198.145.29.136]:34576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbcJ0Otq (ORCPT ); Thu, 27 Oct 2016 10:49:46 -0400 MIME-Version: 1.0 In-Reply-To: <1477429146-27039-3-git-send-email-frowand.list@gmail.com> References: <1477429146-27039-1-git-send-email-frowand.list@gmail.com> <1477429146-27039-3-git-send-email-frowand.list@gmail.com> From: Rob Herring Date: Thu, 27 Oct 2016 07:21:47 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 02/13] of: Remove excessive printks to reduce clutter To: Frank Rowand Cc: Pantelis Antoniou , Pantelis Antoniou , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 26 On Tue, Oct 25, 2016 at 3:58 PM, wrote: > From: Frank Rowand Maybe some should be debug? > Signed-off-by: Frank Rowand > --- > drivers/of/resolver.c | 28 ---------------------------- > 1 file changed, 28 deletions(-) > > diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c > index 4ff0220d7aa2..93a7ca0bf98c 100644 > --- a/drivers/of/resolver.c > +++ b/drivers/of/resolver.c > @@ -116,8 +116,6 @@ static int __of_adjust_phandle_ref(struct device_node *node, > > propval = kmalloc(rprop->length, GFP_KERNEL); > if (!propval) { > - pr_err("%s: Could not copy value of '%s'\n", > - __func__, rprop->name); > return -ENOMEM; > } I would remove the brackets in this patch rather than separately. > memcpy(propval, rprop->value, rprop->length);