Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030403AbcJ0PHD (ORCPT ); Thu, 27 Oct 2016 11:07:03 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48958 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935162AbcJ0PGW (ORCPT ); Thu, 27 Oct 2016 11:06:22 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org E953360388 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap From: Kalle Valo In-Reply-To: <20161017221355.1861551-7-arnd@arndb.de> References: <20161017221355.1861551-7-arnd@arndb.de> To: Arnd Bergmann Cc: Arend van Spriel , Linus Torvalds , linux-kernel@vger.kernel.org, Arnd Bergmann , Hante Meuleman , Franky Lin , Pieter-Paul Giesberts , "Franky (Zhenhui) Lin" , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.3 Message-Id: <20161027150523.B600361656@smtp.codeaurora.org> Date: Thu, 27 Oct 2016 15:05:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 31 Arnd Bergmann wrote: > A bugfix added a sanity check around the assignment and use of the > 'is_11d' variable, which looks correct to me, but as the function is > rather complex already, this confuses the compiler to the point where > it can no longer figure out if the variable is always initialized > correctly: > > brcm80211/brcmfmac/cfg80211.c: In function ‘brcmf_cfg80211_start_ap’: > brcm80211/brcmfmac/cfg80211.c:4586:10: error: ‘is_11d’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This adds an initialization for the newly introduced case in which > the variable should not really be used, in order to make the warning > go away. > > Fixes: b3589dfe0212 ("brcmfmac: ignore 11d configuration errors") > Cc: Hante Meuleman > Cc: Arend van Spriel > Cc: Kalle Valo > Signed-off-by: Arnd Bergmann Patch applied to wireless-drivers.git, thanks. d3532ea6ce4e brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap -- https://patchwork.kernel.org/patch/9380763/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches