Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943426AbcJ0PZf (ORCPT ); Thu, 27 Oct 2016 11:25:35 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:53776 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943389AbcJ0PZ1 (ORCPT ); Thu, 27 Oct 2016 11:25:27 -0400 Date: Thu, 27 Oct 2016 11:25:25 -0400 (EDT) Message-Id: <20161027.112525.2290598329610980726.davem@davemloft.net> To: jkbs@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net Subject: Re: [PATCH net-next 5/5] ipv6: Compute multipath hash for forwarded ICMP errors from offending packet From: David Miller In-Reply-To: <1477301332-23954-6-git-send-email-jkbs@redhat.com> References: <1477301332-23954-1-git-send-email-jkbs@redhat.com> <1477301332-23954-6-git-send-email-jkbs@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 27 Oct 2016 08:25:26 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 557 Lines: 16 From: Jakub Sitnicki Date: Mon, 24 Oct 2016 11:28:52 +0200 > + inner_iph = skb_header_pointer( > + skb, skb_transport_offset(skb) + sizeof(*icmph), > + sizeof(_inner_iph), &_inner_iph); Please do not style this call like this, put as many arguments as you can on the first line. inner_iph = skb_header_pointer(skb, skb_transport_offset(skb) + sizeof(*icmph), sizeof(_inner_iph), &_inner_iph); And on the second and subsequent lines, indent to the first column after the openning parenthesis of the first line.