Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034163AbcJ0QEx (ORCPT ); Thu, 27 Oct 2016 12:04:53 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36359 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935170AbcJ0QEu (ORCPT ); Thu, 27 Oct 2016 12:04:50 -0400 Subject: Re: [RFC PATCH 02/13] of: Remove excessive printks to reduce clutter To: Rob Herring References: <1477429146-27039-1-git-send-email-frowand.list@gmail.com> <1477429146-27039-3-git-send-email-frowand.list@gmail.com> Cc: Pantelis Antoniou , Pantelis Antoniou , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Frank Rowand Message-ID: <58122578.4070208@gmail.com> Date: Thu, 27 Oct 2016 09:04:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1066 Lines: 31 On 10/27/16 05:21, Rob Herring wrote: > On Tue, Oct 25, 2016 at 3:58 PM, wrote: >> From: Frank Rowand > > Maybe some should be debug? > >> Signed-off-by: Frank Rowand >> --- >> drivers/of/resolver.c | 28 ---------------------------- >> 1 file changed, 28 deletions(-) >> >> diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c >> index 4ff0220d7aa2..93a7ca0bf98c 100644 >> --- a/drivers/of/resolver.c >> +++ b/drivers/of/resolver.c >> @@ -116,8 +116,6 @@ static int __of_adjust_phandle_ref(struct device_node *node, >> >> propval = kmalloc(rprop->length, GFP_KERNEL); >> if (!propval) { >> - pr_err("%s: Could not copy value of '%s'\n", >> - __func__, rprop->name); >> return -ENOMEM; >> } > > I would remove the brackets in this patch rather than separately. > >> memcpy(propval, rprop->value, rprop->length); > . > OK, I will collapse the "remove braces" patch into this patch.