Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935082AbcJ0QeR (ORCPT ); Thu, 27 Oct 2016 12:34:17 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:34915 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbcJ0QeQ (ORCPT ); Thu, 27 Oct 2016 12:34:16 -0400 MIME-Version: 1.0 In-Reply-To: <20161027063356.GA547@infradead.org> References: <20161026184201.6ofblkd3j5uxystq@codemonkey.org.uk> <488f9edc-6a1c-2c68-0d33-d3aa32ece9a4@fb.com> <20161026224025.mou27kki4bslftli@codemonkey.org.uk> <2bdc068d-afd5-7a78-f334-26970c91aaca@fb.com> <20161027063356.GA547@infradead.org> From: Linus Torvalds Date: Thu, 27 Oct 2016 09:34:06 -0700 X-Google-Sender-Auth: uunfTvUt7XC6wZABG_pn8ogomrc Message-ID: Subject: Re: bio linked list corruption. To: Christoph Hellwig Cc: Jens Axboe , Dave Jones , Chris Mason , Andy Lutomirski , Andy Lutomirski , Al Viro , Josef Bacik , David Sterba , linux-btrfs , Linux Kernel , Dave Chinner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 640 Lines: 17 On Wed, Oct 26, 2016 at 11:33 PM, Christoph Hellwig wrote: >> Dave, can you hit the warnings with this? Totally untested... > > Can we just kill off the unhelpful blk_map_ctx structure, e.g.: Yeah, I found that hard to read too. The difference between blk_map_ctx and blk_mq_alloc_data is minimal, might as well just use the latter everywhere. But please separate that patch from the patch that fixes the ctx list corruption. And Jens - can I have at least the corruption fix asap? Due to KS travel, I'm going to do rc3 on Saturday, and I'd like to have the fix in at least a day before that.. Linus