Subject: Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols
To: Pantelis Antoniou <panto@antoniou-consulting.com>
References: <1477429146-27039-1-git-send-email-frowand.list@gmail.com>
 <1477429146-27039-14-git-send-email-frowand.list@gmail.com>
 <27823D48-C6B1-486C-8460-9B3C33DDC62F@antoniou-consulting.com>
 <58122AF9.3040709@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
        devicetree <devicetree@vger.kernel.org>, linux-kernel@vger.kernel.org
From: Frank Rowand <frowand.list@gmail.com>
Message-ID: <58123122.8020908@gmail.com>
Date: Thu, 27 Oct 2016 09:53:54 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <58122AF9.3040709@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 35

On 10/27/16 09:27, Frank Rowand wrote:
> On 10/27/16 07:41, Pantelis Antoniou wrote:
>> Hi Frank,
>>
>>
>>> On Oct 25, 2016, at 23:59 , frowand.list@gmail.com wrote:
>>>
>>> From: Frank Rowand <frank.rowand@am.sony.com>
>>>
>>> This unused variable is a reminder that symbols in overlays are
>>> not available to subsequent overlays.  If such a feature is
>>> desired then there are several ways it could be implemented.
>>>
>>
>> Please don’t apply that. There’s a patch that actually imports
>> the symbol table from overlays that subsequent operations
>> work.
>>
>> Please see:
>>
>> https://patchwork.kernel.org/patch/9104701/
> 
> Thanks for the pointer!  When the import symbols patch is applied
> then the comment in my patch header becomes incorrect.  I will
> change the patch comment to act is if the import symbols patch
> is in place.
> 
> But the node pointer that my patch removes is still not used
> for anything, even if the import symbols patch is applied.
> 
> Am I missing something?

I was missing a later patch in the symbol import patch set that
updated resolver.c to use the imported symbols.  I'll go look
at that.