Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942467AbcJ0Q6h (ORCPT ); Thu, 27 Oct 2016 12:58:37 -0400 Received: from mail.kernel.org ([198.145.29.136]:57564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936553AbcJ0Q6d (ORCPT ); Thu, 27 Oct 2016 12:58:33 -0400 MIME-Version: 1.0 In-Reply-To: <58122CC0.3090700@gmail.com> References: <1477429146-27039-1-git-send-email-frowand.list@gmail.com> <1477429146-27039-7-git-send-email-frowand.list@gmail.com> <58122CC0.3090700@gmail.com> From: Rob Herring Date: Thu, 27 Oct 2016 11:58:00 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 06/13] of: Remove prefix "__of_" and prefix "__" from local function names To: Frank Rowand Cc: Pantelis Antoniou , Pantelis Antoniou , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 31 On Thu, Oct 27, 2016 at 11:35 AM, Frank Rowand wrote: > On 10/27/16 05:47, Rob Herring wrote: >> On Tue, Oct 25, 2016 at 3:58 PM, wrote: >>> From: Frank Rowand >> >> I prefer to leave the prefixes and this is getting into pointless churn. >> >>> >>> Signed-off-by: Frank Rowand >>> --- >>> drivers/of/resolver.c | 10 +++++----- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >> > > If I was just submitting this as a single patch, I would agree. > > But since I am making so many other changes, I think it makes > sense to do this as part of this series. It is broken apart > as a separate patch to be easy to review and not pollute any > of the other patches in the series. > > The prefixes add no value for a local function, but they do > add noise when reading code. The value is when reading the calling function, you know the function is a DT related function. You don't know it's a static function without looking up the function name. That said, I wouldn't object to code originally written either way, I just don't see the value in changing it. Rob