Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942300AbcJ0SHX (ORCPT ); Thu, 27 Oct 2016 14:07:23 -0400 Received: from mail.skyhub.de ([78.46.96.112]:59861 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933792AbcJ0SHU (ORCPT ); Thu, 27 Oct 2016 14:07:20 -0400 Date: Thu, 27 Oct 2016 20:07:16 +0200 From: Borislav Petkov To: Aaron Miller Cc: Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC: expose per-dimm error counts in sysfs Message-ID: <20161027180716.a5z6w2g5arco564h@pd.tnic> References: <20161025232551.3270769-1-aaronmiller@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161025232551.3270769-1-aaronmiller@fb.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1271 Lines: 42 On Tue, Oct 25, 2016 at 04:25:51PM -0700, Aaron Miller wrote: <--- This patch needs a commit message. Especially as to *why* we need this. > Signed-off-by: Aaron Miller > --- > drivers/edac/edac_mc_sysfs.c | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) Regardless, something's still not right yet: $ echo 1 > /sys/kernel/debug/edac/mc0/fake_inject_channel $ echo 2 > /sys/kernel/debug/edac/mc0/fake_inject_slot $ echo 3 > /sys/kernel/debug/edac/mc0/fake_inject_count ^ $ echo 1 > /sys/kernel/debug/edac/mc0/fake_inject $ grep . /sys/devices/system/edac/mc/mc0/*count /sys/devices/system/edac/mc/mc0/ce_count:3 ^ /sys/devices/system/edac/mc/mc0/ce_noinfo_count:0 /sys/devices/system/edac/mc/mc0/ue_count:0 /sys/devices/system/edac/mc/mc0/ue_noinfo_count:0 $ grep -r . /sys/devices/system/edac/mc/mc0/dimm*/* 2>/dev/null | grep ce_count /sys/devices/system/edac/mc/mc0/dimm0/dimm_ce_count:0 /sys/devices/system/edac/mc/mc0/dimm3/dimm_ce_count:0 /sys/devices/system/edac/mc/mc0/dimm6/dimm_ce_count:0 /sys/devices/system/edac/mc/mc0/dimm9/dimm_ce_count:0 ^ There should be 3 somewhere in the DIMM counters... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.