Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941929AbcJ0STG (ORCPT ); Thu, 27 Oct 2016 14:19:06 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:49919 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754371AbcJ0STE (ORCPT ); Thu, 27 Oct 2016 14:19:04 -0400 Date: Thu, 27 Oct 2016 16:18:57 -0200 From: Mauro Carvalho Chehab To: Borislav Petkov Cc: Aaron Miller , Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC: expose per-dimm error counts in sysfs Message-ID: <20161027161857.0c2a534a@vento.lan> In-Reply-To: <20161027180716.a5z6w2g5arco564h@pd.tnic> References: <20161025232551.3270769-1-aaronmiller@fb.com> <20161027180716.a5z6w2g5arco564h@pd.tnic> Organization: Samsung X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1461 Lines: 49 Em Thu, 27 Oct 2016 20:07:16 +0200 Borislav Petkov escreveu: > On Tue, Oct 25, 2016 at 04:25:51PM -0700, Aaron Miller wrote: > > <--- This patch needs a commit message. > > Especially as to *why* we need this. Also, if you're changing the sysfs ABI, you need to update the EDAC documentation accordingly. > > > Signed-off-by: Aaron Miller > > --- > > drivers/edac/edac_mc_sysfs.c | 38 ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > Regardless, something's still not right yet: > > $ echo 1 > /sys/kernel/debug/edac/mc0/fake_inject_channel > $ echo 2 > /sys/kernel/debug/edac/mc0/fake_inject_slot > $ echo 3 > /sys/kernel/debug/edac/mc0/fake_inject_count > ^ > > $ echo 1 > /sys/kernel/debug/edac/mc0/fake_inject > > $ grep . /sys/devices/system/edac/mc/mc0/*count > /sys/devices/system/edac/mc/mc0/ce_count:3 > ^ > > /sys/devices/system/edac/mc/mc0/ce_noinfo_count:0 > /sys/devices/system/edac/mc/mc0/ue_count:0 > /sys/devices/system/edac/mc/mc0/ue_noinfo_count:0 > > $ grep -r . /sys/devices/system/edac/mc/mc0/dimm*/* 2>/dev/null | grep ce_count > /sys/devices/system/edac/mc/mc0/dimm0/dimm_ce_count:0 > /sys/devices/system/edac/mc/mc0/dimm3/dimm_ce_count:0 > /sys/devices/system/edac/mc/mc0/dimm6/dimm_ce_count:0 > /sys/devices/system/edac/mc/mc0/dimm9/dimm_ce_count:0 > ^ > > There should be 3 somewhere in the DIMM counters... > Thanks, Mauro