Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942590AbcJ0TLZ (ORCPT ); Thu, 27 Oct 2016 15:11:25 -0400 Received: from smtpo.poczta.interia.pl ([217.74.65.206]:60966 "EHLO smtpo.poczta.interia.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935449AbcJ0TLY (ORCPT ); Thu, 27 Oct 2016 15:11:24 -0400 X-Interia-R: Interia X-Interia-R-IP: 188.121.17.172 X-Interia-R-Helo: Date: Thu, 27 Oct 2016 21:11:43 +0200 From: Slawomir Stepien To: Dmitry Torokhov Cc: ldewangan@nvidia.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Input: gpio-keys - use module_platform_driver macro Message-ID: <20161027191143.GA1630@x220.localdomain> References: <20161027141554.GA31977@x220.localdomain> <20161027164830.GB36933@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161027164830.GB36933@dtor-ws> User-Agent: Mutt/1.7.1 (2016-10-04) X-Interia-Antivirus: OK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 773 Lines: 28 On Oct 27, 2016 09:48, Dmitry Torokhov wrote: > Hi Slawomir, Hi Dmitry, > > -late_initcall(gpio_keys_init); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Because of this we can't switch to module_platform_driver(). The > late_initcall was requirement of one of platforms because of the probe > ordering issues. It may be resolved now with deferred probing, but you'd > need to confirm with all the users. I was unaware of that. Let me look in to that more deeply. At the moment I do not have the knowledge what will be to correct solution for that. > > -module_exit(gpio_keys_exit); > > +module_platform_driver(gpio_keys_device_driver); > > > > MODULE_LICENSE("GPL"); > > MODULE_AUTHOR("Phil Blundell "); > > Thanks. Thank you. -- Slawomir Stepien