Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941966AbcJ0VDe (ORCPT ); Thu, 27 Oct 2016 17:03:34 -0400 Received: from mga14.intel.com ([192.55.52.115]:37182 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934631AbcJ0VDb (ORCPT ); Thu, 27 Oct 2016 17:03:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,553,1473145200"; d="scan'208";a="1076874993" Date: Thu, 27 Oct 2016 22:03:29 +0100 From: Giovanni Cabiddu To: Arnd Bergmann Cc: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: acomp: export all scomp interfaces Message-ID: <20161027210328.GA12705@SILVIXA00369791-F22-1> References: <20161027141029.2566709-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161027141029.2566709-1-arnd@arndb.de> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 21 Hi Arnd, On Thu, Oct 27, 2016 at 04:09:49PM +0200, Arnd Bergmann wrote: > The newly added scomp/acomp interface has a couple of functions > that should be exported to allow linking the two drivers > as loadable modules: > > ERROR: "crypto_acomp_scomp_free_ctx" [crypto/acompress.ko] undefined! > ERROR: "crypto_acomp_scomp_alloc_ctx" [crypto/acompress.ko] undefined! > ERROR: "crypto_init_scomp_ops_async" [crypto/acompress.ko] undefined! These functions were not exported on purpose. They should not be called by other modules. > Alternatively, both of them could be combined into one loadable module. I think this is the correct approach. Here is a patch with an alternative fix: https://patchwork.kernel.org/patch/9396503/ Thanks, -- Giovanni