Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942267AbcJ0VjX (ORCPT ); Thu, 27 Oct 2016 17:39:23 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33091 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935747AbcJ0VjW (ORCPT ); Thu, 27 Oct 2016 17:39:22 -0400 Date: Fri, 28 Oct 2016 00:39:18 +0300 From: Cyrill Gorcunov To: "Eric W. Biederman" Cc: Kees Cook , Andrey Vagin , LKML , Pavel Emelyanov , Linux Containers , Jann Horn Subject: Re: [REVIEW][PATCH v2] mm: Add a user_ns owner to mm_struct and fix ptrace permission checks Message-ID: <20161027213918.GA1922@uranus.lan> References: <20161024105959.GQ1847@uranus.lan> <8760oh8tbp.fsf@xmission.com> <20161024202925.GS1847@uranus.lan> <8760oh737b.fsf@xmission.com> <20161025090213.GX1847@uranus.lan> <87d1ilrdmt.fsf_-_@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d1ilrdmt.fsf_-_@xmission.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 18 On Thu, Oct 27, 2016 at 10:54:34AM -0500, Eric W. Biederman wrote: > > > I can't imagine either of these changes making a practical difference > to anyone but I am calling them out in case someone can. > > include/linux/mm_types.h | 1 + > kernel/fork.c | 9 ++++++--- > kernel/ptrace.c | 26 +++++++++++--------------- > mm/init-mm.c | 2 ++ > 4 files changed, 20 insertions(+), 18 deletions(-) Thanks a huge, Eric! And really sorry for delay in response, I managed to miss this quite important mail for me in mail storm. Gonna test it and will write you the results. Overall looks great, but better be sure and run the tests. Reviewed-by: Cyrill Gorcunov