Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941855AbcJ0WAT (ORCPT ); Thu, 27 Oct 2016 18:00:19 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37543 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933375AbcJ0WAR (ORCPT ); Thu, 27 Oct 2016 18:00:17 -0400 User-agent: mu4e 0.9.17; emacs 25.1.1 From: Jakub Sitnicki To: David Miller Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, edumazet@google.com Subject: Re: [PATCH net-next 4/5] ipv6: Compute multipath hash for sent ICMP errors from offending packet In-reply-to: <20161027.112413.1616222035100737672.davem@davemloft.net> Date: Fri, 28 Oct 2016 00:00:14 +0200 Message-ID: <87h97xv4ep.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 19 On Thu, Oct 27, 2016 at 03:24 PM GMT, David Miller wrote: > From: Jakub Sitnicki > Date: Mon, 24 Oct 2016 11:28:51 +0200 > >> diff --git a/include/linux/icmpv6.h b/include/linux/icmpv6.h >> index 57086e9..6282e03 100644 >> --- a/include/linux/icmpv6.h >> +++ b/include/linux/icmpv6.h >> @@ -45,4 +45,6 @@ extern void icmpv6_flow_init(struct sock *sk, >> const struct in6_addr *saddr, >> const struct in6_addr *daddr, >> int oif); >> +struct ipv6hdr; >> +extern u32 icmpv6_multipath_hash(const struct ipv6hdr *iph); >> #endif > > We do not use "extern" in external function declarations in header file any more. My mistake, will remote it.