Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034402AbcJ0Xdt (ORCPT ); Thu, 27 Oct 2016 19:33:49 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46194 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034149AbcJ0Xdq (ORCPT ); Thu, 27 Oct 2016 19:33:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org F21BB615FA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 27 Oct 2016 16:33:44 -0700 From: Stephen Boyd To: Laura Abbott Cc: Michael Turquette , Loc Ho , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: xgene: Don't call __pa on ioremaped address Message-ID: <20161027233344.GF26139@codeaurora.org> References: <1477610508-7449-1-git-send-email-labbott@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 18 On 10/27, Laura Abbott wrote: > On 10/27/2016 04:21 PM, Laura Abbott wrote: > > > >@@ -269,7 +267,7 @@ static int xgene_clk_enable(struct clk_hw *hw) > > xgene_clk_write(data, pclk->param.csr_reg + > > pclk->param.reg_csr_offset); > > pr_debug("%s CSR RESET PADDR base %pa csr offset 0x%08X mask 0x%08X value 0x%08X\n", > > Bah, this got fixed locally but didn't get amended. I'll remove > the format here in a v2 assuming there are no other objections. > Include a Fixes: tag too? It would be nice if sparse complained about __pa used on an __iomem pointer too. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project