From: Sriram Dash <sriram.dash@nxp.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "mathias.nyman@intel.com" <mathias.nyman@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Suresh Gupta <suresh.gupta@nxp.com>,
        "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
        "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
        "pku.leo@gmail.com" <pku.leo@gmail.com>
Subject: RE: [PATCH 3/3] usb: dwc3: host: Do not use
 dma_coerce_mask_and_coherent
Thread-Topic: [PATCH 3/3] usb: dwc3: host: Do not use
 dma_coerce_mask_and_coherent
Thread-Index: AQHSLq6Rf6gZiIzL0kywGQlKaruoC6C5nxaAgAIpY+A=
Date: Thu, 27 Oct 2016 05:28:52 +0000
Message-ID: <DB5PR0401MB19255634BE1886D91C3D1308F5AA0@DB5PR0401MB1925.eurprd04.prod.outlook.com>
References: <1477392988-7253-1-git-send-email-sriram.dash@nxp.com>
 <1477392988-7253-4-git-send-email-sriram.dash@nxp.com>
 <4598901.ugkIQYLvkL@wuerfel>
In-Reply-To: <4598901.ugkIQYLvkL@wuerfel>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2016 05:28:52.6590
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1349
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9S11Wo4011621
Content-Length: 867
Lines: 25

>From: Arnd Bergmann [mailto:arnd@arndb.de]
>On Tuesday, October 25, 2016 4:26:28 PM CEST Sriram Dash wrote:
>> Do not use dma_coerce_mask_and_coherent for hcd.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
>The patch is good, but please follow the usual rules for submitting someone else's
>patch:
>
>- As the first line, have "From: Arnd Bergmann <arnd@arndb.de>".
>  "git format-patch" adds this automatically if you pass that
>  address as the "--author" argument to "git commit".
>
>- Add you "Signed-off-by" line at below mine (or any other lines)
>
>I would also suggest a more elaborate changelog text, the free-form text should
>explain why something is done, rather than repeat the subject:
>
>| The dma mask is correctly set up by the DT probe function, no need to
>| override it any more.
>

Ok Arnd. I will take care for the next version.

>	Arnd