Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941720AbcJ1CuE convert rfc822-to-8bit (ORCPT ); Thu, 27 Oct 2016 22:50:04 -0400 Received: from mga14.intel.com ([192.55.52.115]:32737 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933375AbcJ1CuD (ORCPT ); Thu, 27 Oct 2016 22:50:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,407,1473145200"; d="scan'208";a="1051485436" From: "Brown, Aaron F" To: David Singleton , "Kirsher, Jeffrey T" CC: khalidm , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] e1000e: x86: e1000 driver trying to free already-free irq. Thread-Topic: [PATCH] e1000e: x86: e1000 driver trying to free already-free irq. Thread-Index: AQHSKJm3a2w8Ppoz0k+Bg7zFkr4KkKC9OpOg Date: Fri, 28 Oct 2016 02:50:01 +0000 Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B81FBD577@ORSMSX101.amr.corp.intel.com> References: <20161017165108.29718-5-davsingl@cisco.com> In-Reply-To: <20161017165108.29718-5-davsingl@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWMxOTgyZDgtNjRjMy00NzcwLWIxMmYtMmExZGQ0MDUyZTZmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRJZFhaQ2c1THBabVRzYVJ6RnFpZEJINkhsUmtQdWx1eWFkQUxiY2tWcXM9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1308 Lines: 27 > From: netdev-owner@vger.kernel.org [mailto:netdev- > owner@vger.kernel.org] On Behalf Of David Singleton > Sent: Monday, October 17, 2016 9:51 AM > To: Kirsher, Jeffrey T > Cc: khalidm ; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] e1000e: x86: e1000 driver trying to free already-free irq. > > From: khalidm > > During systemd reboot sequence network driver interface is shutdown > by e1000_close. The PCI driver interface is shut by e1000_shutdown. > The e1000_shutdown checks for netif_running status, if still up it > brings down driver. But it disables msi outside of this if statement, > regardless of netif status. All this is OK when e1000_close happens > after shutdown. However, by default, everything in systemd is done > in parallel. This creates a conditions where e1000_shutdown is called > after e1000_close, therefore hitting BUG_ON assert in free_msi_irqs. > > Cc-Id: xe-kernel@external.cisco.com > Signed-off-by: khalidm > Signed-off-by: David Singleton > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Aaron Brown