Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756078AbcJ1GVp (ORCPT ); Fri, 28 Oct 2016 02:21:45 -0400 Received: from mail-db5eur01on0086.outbound.protection.outlook.com ([104.47.2.86]:65440 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750961AbcJ1GVk (ORCPT ); Fri, 28 Oct 2016 02:21:40 -0400 From: "Y.B. Lu" To: "Y.B. Lu" , Scott Wood , "linux-mmc@vger.kernel.org" , "ulf.hansson@linaro.org" , Arnd Bergmann CC: "linuxppc-dev@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "netdev@vger.kernel.org" , Greg Kroah-Hartman , Mark Rutland , Rob Herring , Russell King , Jochen Friedrich , Joerg Roedel , Claudiu Manoil , Bhupesh Sharma , Qiang Zhao , Kumar Gala , Santosh Shilimkar , Leo Li , "X.B. Xie" , "M.H. Lian" Subject: RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms Thread-Topic: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms Thread-Index: AQHSMM3QKy+qN67FLECAeMpeyHFYfKC9SrsAgAAUfwCAAAG0sA== Date: Fri, 28 Oct 2016 06:06:10 +0000 Message-ID: References: <1477625554-46700-1-git-send-email-yangbo.lu@nxp.com> <1477625554-46700-6-git-send-email-yangbo.lu@nxp.com> <1477629956.6812.15.camel@buserror.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yangbo.lu@nxp.com; x-originating-ip: [199.59.225.131] x-ms-office365-filtering-correlation-id: 9db0fbd4-1828-4009-9993-08d3fef88402 x-microsoft-exchange-diagnostics: 1;DB6PR0401MB2536;7:5owkq3sglCzNKPFWpx0BFiL+IyAZWC1anc3Xdzhbulpj0LQ6Z9tnA0qtVuJU1p2pbKT1KKUqfNzV3BCQVcDTRUAEHxTP9jYfQICISOEtOxNVMxclGiVnbk8hO99kpS61ayReLZDzQLdeavmaztP2i2tzYXSXXQbo59iqRhfNIp3g2FOZtKsiPVakjAbrdbXAOyGBJ0A1mghf+eM4uJZK17aDJxzMyjCsXvPOjJrmmRLy2oga/I9cblX2ubS6xCWkWCyzSxCvCneIEfk4k0c7+Usi38GHOrnTD95yYPw2I2EGkBXzelCgeOxtUSEBHxVYx9t54xmDosXHPCw2rYLLigmoxfwasO1Z1MA/8u7f+6E= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2536; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(65623756079841)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(6045074)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6046074)(6072074);SRVR:DB6PR0401MB2536;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2536; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(377424004)(189002)(199003)(24454002)(13464003)(11100500001)(586003)(66066001)(97736004)(2501003)(5001770100001)(4001150100001)(9686002)(8936002)(5002640100001)(7846002)(105586002)(106116001)(4326007)(87936001)(106356001)(10400500002)(50986999)(2201001)(3660700001)(122556002)(3280700002)(3846002)(6116002)(33656002)(7736002)(92566002)(7416002)(2906002)(305945005)(74316002)(5660300001)(189998001)(3900700001)(2900100001)(8676002)(19580405001)(19580395003)(77096005)(102836003)(68736007)(54356999)(101416001)(76176999)(81166006)(15975445007)(7696004)(81156014)(86362001)(76576001)(422495003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0401MB2536;H:DB6PR0401MB2536.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2016 06:06:10.7307 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9S6LrDh012835 Content-Length: 3007 Lines: 76 > -----Original Message----- > From: Y.B. Lu > Sent: Friday, October 28, 2016 2:00 PM > To: 'Scott Wood'; linux-mmc@vger.kernel.org; ulf.hansson@linaro.org; Arnd > Bergmann > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > clk@vger.kernel.org; linux-i2c@vger.kernel.org; iommu@lists.linux- > foundation.org; netdev@vger.kernel.org; Greg Kroah-Hartman; Mark Rutland; > Rob Herring; Russell King; Jochen Friedrich; Joerg Roedel; Claudiu Manoil; > Bhupesh Sharma; Qiang Zhao; Kumar Gala; Santosh Shilimkar; Leo Li; X.B. > Xie; M.H. Lian > Subject: RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms > > > > > -----Original Message----- > > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > > owner@vger.kernel.org] On Behalf Of Scott Wood > > Sent: Friday, October 28, 2016 12:46 PM > > To: Y.B. Lu; linux-mmc@vger.kernel.org; ulf.hansson@linaro.org; Arnd > > Bergmann > > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; > > linux-arm- kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > > linux- clk@vger.kernel.org; linux-i2c@vger.kernel.org; > > iommu@lists.linux- foundation.org; netdev@vger.kernel.org; Greg > > Kroah-Hartman; Mark Rutland; Rob Herring; Russell King; Jochen > > Friedrich; Joerg Roedel; Claudiu Manoil; Bhupesh Sharma; Qiang Zhao; > Kumar Gala; Santosh Shilimkar; Leo Li; X.B. > > Xie; M.H. Lian > > Subject: Re: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms > > > > On Fri, 2016-10-28 at 11:32 +0800, Yangbo Lu wrote: > > > + guts->regs = of_iomap(np, 0); > > > + if (!guts->regs) > > > + return -ENOMEM; > > > + > > > + /* Register soc device */ > > > + machine = of_flat_dt_get_machine_name(); > > > + if (machine) > > > + soc_dev_attr.machine = devm_kstrdup(dev, machine, > > > GFP_KERNEL); > > > + > > > + svr = fsl_guts_get_svr(); > > > + soc_die = fsl_soc_die_match(svr, fsl_soc_die); > > > + if (soc_die) { > > > + soc_dev_attr.family = devm_kasprintf(dev, GFP_KERNEL, > > > +      "QorIQ %s", soc_die- > > > >die); > > > + } else { > > > + soc_dev_attr.family = devm_kasprintf(dev, GFP_KERNEL, > > > "QorIQ"); > > > + } > > > + soc_dev_attr.soc_id = devm_kasprintf(dev, GFP_KERNEL, > > > +      "svr:0x%08x", svr); > > > + soc_dev_attr.revision = devm_kasprintf(dev, GFP_KERNEL, "%d.%d", > > > +        SVR_MAJ(svr), SVR_MIN(svr)); > > > + > > > + soc_dev = soc_device_register(&soc_dev_attr); > > > + if (IS_ERR(soc_dev)) > > > + return PTR_ERR(soc_dev); > > > > ioremap leaks on this error path.  Use devm_ioremap_resource(). > > > > [Lu Yangbo-B47093] Ok. I have fixed it in v14. Thanks :) [Lu Yangbo-B47093] Sorry, used the wrong error code... Will resent it > > > -Scott > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" > > in the body of a message to majordomo@vger.kernel.org More majordomo > > info at http://vger.kernel.org/majordomo-info.html