Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756223AbcJ1Gud (ORCPT ); Fri, 28 Oct 2016 02:50:33 -0400 Received: from terminus.zytor.com ([198.137.202.10]:49426 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbcJ1Gub (ORCPT ); Fri, 28 Oct 2016 02:50:31 -0400 Date: Thu, 27 Oct 2016 23:49:25 -0700 From: tip-bot for Dmitry Safonov Message-ID: Cc: linux-kernel@vger.kernel.org, jpoimboe@redhat.com, luto@kernel.org, brgerst@gmail.com, dvlasenk@redhat.com, mingo@kernel.org, a.p.zijlstra@chello.nl, torvalds@linux-foundation.org, gorcunov@openvz.org, hpa@zytor.com, dsafonov@virtuozzo.com, bp@alien8.de, peterz@infradead.org, tglx@linutronix.de Reply-To: luto@kernel.org, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, mingo@kernel.org, brgerst@gmail.com, dvlasenk@redhat.com, gorcunov@openvz.org, dsafonov@virtuozzo.com, hpa@zytor.com, torvalds@linux-foundation.org, tglx@linutronix.de, peterz@infradead.org, bp@alien8.de In-Reply-To: <20161027141516.28447-3-dsafonov@virtuozzo.com> References: <20161027141516.28447-3-dsafonov@virtuozzo.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/asm] x86/vdso: Set vDSO pointer only after success Git-Commit-ID: 67dece7d4c5841e84a3c795e79bf0dcd5be54f55 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2661 Lines: 78 Commit-ID: 67dece7d4c5841e84a3c795e79bf0dcd5be54f55 Gitweb: http://git.kernel.org/tip/67dece7d4c5841e84a3c795e79bf0dcd5be54f55 Author: Dmitry Safonov AuthorDate: Thu, 27 Oct 2016 17:15:16 +0300 Committer: Ingo Molnar CommitDate: Fri, 28 Oct 2016 08:15:55 +0200 x86/vdso: Set vDSO pointer only after success Those pointers were initialized before call to _install_special_mapping() after the commit: f7b6eb3fa072 ("x86: Set context.vdso before installing the mapping") This is not required anymore as special mappings have their vma name and don't use arch_vma_name() after commit: a62c34bd2a8a ("x86, mm: Improve _install_special_mapping and fix x86 vdso naming") So, this way to init looks less entangled. I even belive that we can remove NULL initializers: - on failure load_elf_binary() will not start a new thread; - arch_prctl will have the same pointers as before syscall. Signed-off-by: Dmitry Safonov Acked-by: Andy Lutomirski Cc: 0x7f454c46@gmail.com Cc: Borislav Petkov Cc: Brian Gerst Cc: Cyrill Gorcunov Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Josh Poimboeuf Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-mm@kvack.org Cc: oleg@redhat.com Link: http://lkml.kernel.org/r/20161027141516.28447-3-dsafonov@virtuozzo.com Signed-off-by: Ingo Molnar --- arch/x86/entry/vdso/vma.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/x86/entry/vdso/vma.c b/arch/x86/entry/vdso/vma.c index 23c881c..e739002 100644 --- a/arch/x86/entry/vdso/vma.c +++ b/arch/x86/entry/vdso/vma.c @@ -161,8 +161,6 @@ static int map_vdso(const struct vdso_image *image, unsigned long addr) } text_start = addr - image->sym_vvar_start; - current->mm->context.vdso = (void __user *)text_start; - current->mm->context.vdso_image = image; /* * MAYWRITE to allow gdb to COW and set breakpoints @@ -189,14 +187,12 @@ static int map_vdso(const struct vdso_image *image, unsigned long addr) if (IS_ERR(vma)) { ret = PTR_ERR(vma); do_munmap(mm, text_start, image->size); + } else { + current->mm->context.vdso = (void __user *)text_start; + current->mm->context.vdso_image = image; } up_fail: - if (ret) { - current->mm->context.vdso = NULL; - current->mm->context.vdso_image = NULL; - } - up_write(&mm->mmap_sem); return ret; }