Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758208AbcJ1HeJ (ORCPT ); Fri, 28 Oct 2016 03:34:09 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35669 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756721AbcJ1HeH (ORCPT ); Fri, 28 Oct 2016 03:34:07 -0400 Date: Fri, 28 Oct 2016 09:34:02 +0200 From: Daniel Vetter To: Gustavo Padovan Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Stone , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Maarten Lankhorst , Brian Starkey , Gustavo Padovan Subject: Re: [PATCH v6 2/6] drm/imx: use drm_atomic_set_fence_for_plane() to set the fence Message-ID: <20161028073402.jy6evm6vahapfdpn@phenom.ffwll.local> Mail-Followup-To: Gustavo Padovan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Stone , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Maarten Lankhorst , Brian Starkey , Gustavo Padovan References: <1477597031-5139-1-git-send-email-gustavo@padovan.org> <1477597031-5139-3-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477597031-5139-3-git-send-email-gustavo@padovan.org> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1537 Lines: 49 On Thu, Oct 27, 2016 at 05:37:07PM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > drm_atomic_set_fence_for_plane() is smart and won't overwrite > plane_state->fence if the user already set an explicit fence there. > > Signed-off-by: Gustavo Padovan Process nit: Please make sure you Cc: driver maintainers for driver patches. Best done by putting the Cc: into the patch, then you never forget ;-) Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/imx/imx-drm-core.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > index 98df09c..07fe955 100644 > --- a/drivers/gpu/drm/imx/imx-drm-core.c > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > @@ -158,6 +158,7 @@ static int imx_drm_atomic_commit(struct drm_device *dev, > struct drm_plane_state *plane_state; > struct drm_plane *plane; > struct dma_buf *dma_buf; > + struct dma_fence *fence; > int i; > > /* > @@ -170,8 +171,9 @@ static int imx_drm_atomic_commit(struct drm_device *dev, > 0)->base.dma_buf; > if (!dma_buf) > continue; > - plane_state->fence = > - reservation_object_get_excl_rcu(dma_buf->resv); > + fence = reservation_object_get_excl_rcu(dma_buf->resv); > + > + drm_atomic_set_fence_for_plane(plane_state, fence); > } > } > > -- > 2.5.5 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch