Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758727AbcJ1Hly (ORCPT ); Fri, 28 Oct 2016 03:41:54 -0400 Received: from mail-he1eur01on0046.outbound.protection.outlook.com ([104.47.0.46]:51419 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751549AbcJ1Hlu (ORCPT ); Fri, 28 Oct 2016 03:41:50 -0400 X-Greylist: delayed 5171 seconds by postgrey-1.27 at vger.kernel.org; Fri, 28 Oct 2016 03:41:48 EDT From: "Y.B. Lu" To: Scott Wood , "linux-mmc@vger.kernel.org" , "ulf.hansson@linaro.org" , Arnd Bergmann CC: "linuxppc-dev@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "netdev@vger.kernel.org" , Greg Kroah-Hartman , Mark Rutland , Rob Herring , Russell King , Jochen Friedrich , Joerg Roedel , Claudiu Manoil , Bhupesh Sharma , Qiang Zhao , Kumar Gala , Santosh Shilimkar , Leo Li , "X.B. Xie" , "M.H. Lian" Subject: RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms Thread-Topic: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms Thread-Index: AQHSMM3QKy+qN67FLECAeMpeyHFYfKC9SrsAgAAUfwCAAAG0sIAAENEg Date: Fri, 28 Oct 2016 07:08:44 +0000 Message-ID: References: <1477625554-46700-1-git-send-email-yangbo.lu@nxp.com> <1477625554-46700-6-git-send-email-yangbo.lu@nxp.com> <1477629956.6812.15.camel@buserror.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yangbo.lu@nxp.com; x-originating-ip: [199.59.225.131] x-ms-office365-filtering-correlation-id: 73fc67a3-af63-4210-21f8-08d3ff014134 x-microsoft-exchange-diagnostics: 1;DB6PR0401MB2534;7:WvMW7wykhN86rnMo759mD+5wN30S10/AxA1rhwyqTzsGlGzp3PIUQZetZIADWSobVTgdOMtDLIyQgxaWoQnYau6f/OSJMFBbPtr4Xxtlst+IUC6NVKKR4TvrvaNIs/Eb6nBFZ3KthZObuOKdm/zTkUSXYYHl+gXh6yzPOB/IOv5C9IThrRh08HBRt9zqUK/kq46qMukIavFuKyhXmj9J5GR6z+Px5haaiDP87JEmdsetodm1sI6GK/P26xo4Hn4Oy27pLx6kZBiysKyLooy0MQtjJcdUg4qfnq/BMnkcyyxXyYfXMH25N5/auBQ+QODbvk6UUQf30qwcIBXOPGHnoY9aO3yIz0Y7CdR4jmKtRSc= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2534; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(65623756079841)(258649278758335)(84791874153150); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6060202)(6040176)(6045074)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6046074)(6072074);SRVR:DB6PR0401MB2534;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2534; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(13464003)(377424004)(24454002)(189002)(199003)(377454003)(8936002)(86362001)(10400500002)(81166006)(122556002)(305945005)(2201001)(7736002)(7846002)(74316002)(81156014)(3900700001)(3280700002)(4326007)(8676002)(87936001)(586003)(2906002)(3660700001)(2501003)(101416001)(102836003)(19580405001)(4001150100001)(189998001)(33656002)(54356999)(76176999)(92566002)(7696004)(5660300001)(106116001)(76576001)(106356001)(7416002)(9686002)(66066001)(15975445007)(5001770100001)(105586002)(5002640100001)(19580395003)(50986999)(6116002)(3846002)(77096005)(2900100001)(68736007)(11100500001)(97736004)(422495003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0401MB2534;H:DB6PR0401MB2536.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2016 07:08:44.1756 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2534 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9S7fxoR013267 Content-Length: 4312 Lines: 101 > -----Original Message----- > From: Y.B. Lu > Sent: Friday, October 28, 2016 2:06 PM > To: Y.B. Lu; 'Scott Wood'; 'linux-mmc@vger.kernel.org'; > 'ulf.hansson@linaro.org'; 'Arnd Bergmann' > Cc: 'linuxppc-dev@lists.ozlabs.org'; 'devicetree@vger.kernel.org'; > 'linux-arm-kernel@lists.infradead.org'; 'linux-kernel@vger.kernel.org'; > 'linux-clk@vger.kernel.org'; 'linux-i2c@vger.kernel.org'; > 'iommu@lists.linux-foundation.org'; 'netdev@vger.kernel.org'; 'Greg > Kroah-Hartman'; 'Mark Rutland'; 'Rob Herring'; 'Russell King'; 'Jochen > Friedrich'; 'Joerg Roedel'; 'Claudiu Manoil'; 'Bhupesh Sharma'; Qiang > Zhao; 'Kumar Gala'; 'Santosh Shilimkar'; Leo Li; X.B. Xie; M.H. Lian > Subject: RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms > > > -----Original Message----- > > From: Y.B. Lu > > Sent: Friday, October 28, 2016 2:00 PM > > To: 'Scott Wood'; linux-mmc@vger.kernel.org; ulf.hansson@linaro.org; > > Arnd Bergmann > > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; > > linux-arm- kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > > linux- clk@vger.kernel.org; linux-i2c@vger.kernel.org; > > iommu@lists.linux- foundation.org; netdev@vger.kernel.org; Greg > > Kroah-Hartman; Mark Rutland; Rob Herring; Russell King; Jochen > > Friedrich; Joerg Roedel; Claudiu Manoil; Bhupesh Sharma; Qiang Zhao; > Kumar Gala; Santosh Shilimkar; Leo Li; X.B. > > Xie; M.H. Lian > > Subject: RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms > > > > > > > > > -----Original Message----- > > > From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc- > > > owner@vger.kernel.org] On Behalf Of Scott Wood > > > Sent: Friday, October 28, 2016 12:46 PM > > > To: Y.B. Lu; linux-mmc@vger.kernel.org; ulf.hansson@linaro.org; Arnd > > > Bergmann > > > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; > > > linux-arm- kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > > > linux- clk@vger.kernel.org; linux-i2c@vger.kernel.org; > > > iommu@lists.linux- foundation.org; netdev@vger.kernel.org; Greg > > > Kroah-Hartman; Mark Rutland; Rob Herring; Russell King; Jochen > > > Friedrich; Joerg Roedel; Claudiu Manoil; Bhupesh Sharma; Qiang Zhao; > > Kumar Gala; Santosh Shilimkar; Leo Li; X.B. > > > Xie; M.H. Lian > > > Subject: Re: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ > > > platforms > > > > > > On Fri, 2016-10-28 at 11:32 +0800, Yangbo Lu wrote: > > > > + guts->regs = of_iomap(np, 0); > > > > + if (!guts->regs) > > > > + return -ENOMEM; > > > > + > > > > + /* Register soc device */ > > > > + machine = of_flat_dt_get_machine_name(); > > > > + if (machine) > > > > + soc_dev_attr.machine = devm_kstrdup(dev, machine, > > > > GFP_KERNEL); > > > > + > > > > + svr = fsl_guts_get_svr(); > > > > + soc_die = fsl_soc_die_match(svr, fsl_soc_die); > > > > + if (soc_die) { > > > > + soc_dev_attr.family = devm_kasprintf(dev, GFP_KERNEL, > > > > +      "QorIQ %s", soc_die- > > > > >die); > > > > + } else { > > > > + soc_dev_attr.family = devm_kasprintf(dev, GFP_KERNEL, > > > > "QorIQ"); > > > > + } > > > > + soc_dev_attr.soc_id = devm_kasprintf(dev, GFP_KERNEL, > > > > +      "svr:0x%08x", svr); > > > > + soc_dev_attr.revision = devm_kasprintf(dev, GFP_KERNEL, > "%d.%d", > > > > +        SVR_MAJ(svr), SVR_MIN(svr)); > > > > + > > > > + soc_dev = soc_device_register(&soc_dev_attr); > > > > + if (IS_ERR(soc_dev)) > > > > + return PTR_ERR(soc_dev); > > > > > > ioremap leaks on this error path.  Use devm_ioremap_resource(). > > > > > > > [Lu Yangbo-B47093] Ok. I have fixed it in v14. Thanks :) > > [Lu Yangbo-B47093] Sorry, used the wrong error code... Will resent it [Lu Yangbo-B47093] The v15 had been sent. And dropped patch 'dt: bindings: update Freescale DCFG compatible', since that work has been done by below patch on ShawnGuo's linux tree. 'dt-bindings: fsl: add LS1043A/LS1046A/LS2080A compatible for SCFG and DCFG' https://git.kernel.org/cgit/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/dt64&id=981034a2bfcaff5c95dafde24d7abfe7f9025c19 Thanks. > > > > > > -Scott > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" > > > in the body of a message to majordomo@vger.kernel.org More majordomo > > > info at http://vger.kernel.org/majordomo-info.html