Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S941802AbcJ1HxD (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Oct 2016 03:53:03 -0400
Received: from smtpoutz25.laposte.net ([194.117.213.100]:51175 "EHLO
        smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S935453AbcJ1Hw6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Oct 2016 03:52:58 -0400
Date: Fri, 28 Oct 2016 09:52:54 +0200
From: Vincent =?iso-8859-1?Q?Stehl=E9?= <vincent.stehle@laposte.net>
Cc: linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Mauro Carvalho Chehab <mchehab@s-opensource.com>
Subject: Re: [PATCH next 1/2] media: mtk-mdp: fix video_device_release
 argument
Message-ID: <20161028075253.gdy2bbugih6oqncw@romuald.bergerie>
References: <1473340146-6598-4-git-send-email-minghsiu.tsai@mediatek.com>
 <20161027202325.20680-1-vincent.stehle@laposte.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20161027202325.20680-1-vincent.stehle@laposte.net>
User-Agent: NeoMutt/20161014 (1.7.1)
X-VR-SrcIP: 88.178.86.202
X-VR-FullState: 0
X-VR-Score: -70
X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeelvddrjedvgddufedvucetufdoteggodetrfdotffvucfrrhho
X-VR-Cause-2: fhhilhgvmecunfetrffquffvgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhht
X-VR-Cause-3: shculddquddttddmnehmihhsshhinhhgucfvqfcufhhivghlugculdeftddmnecujfgurhepfffhuffk
X-VR-Cause-4: fhggtggugfgjfgesthektddttderudenucfhrhhomhepgghinhgtvghnthcuufhtvghhlhoruceovhhi
X-VR-Cause-5: nhgtvghnthdrshhtvghhlhgvsehlrghpohhsthgvrdhnvghtqeenucfkphepkeekrddujeekrdekiedr
X-VR-Cause-6: vddtvdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehrohhmuhgrlhgurdgsvghr
X-VR-Cause-7: ghgvrhhivgdpihhnvghtpeekkedrudejkedrkeeirddvtddvpdhmrghilhhfrhhomhepvhhinhgtvghn
X-VR-Cause-8: thdrshhtvghhlhgvsehlrghpohhsthgvrdhnvghtpdhrtghpthhtoheplhhinhhugidqmhgvughirges
X-VR-Cause-9: vhhgvghrrdhkvghrnhgvlhdrohhrgh
X-VR-AvState: No
X-VR-State: 0
X-VR-State: 0
To: unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 620
Lines: 17

On Thu, Oct 27, 2016 at 10:23:24PM +0200, Vincent Stehl? wrote:
> video_device_release() takes a pointer to struct video_device as argument.
> Fix two call sites where the address of the pointer is passed instead.

Sorry, I messed up: please ignore that "fix". The 0day robot made me
realize this is indeed not a proper fix.

The issue remains, though: we cannot call video_device_release() on the
vdev structure member, as this will in turn call kfree(). Most probably,
vdev needs to be dynamically allocated, or the call to
video_device_release() dropped completely.

Sorry for the bad patch.

Best regards,

Vincent.