Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758844AbcJ1H6S (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Oct 2016 03:58:18 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:43750 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755920AbcJ1H6R (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Oct 2016 03:58:17 -0400
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Fri, 28 Oct 2016 00:58:16 -0700
From: Vikram Mulukutla <markivx@codeaurora.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Srivatsa Vaddagiri <vatsa@codeaurora.org>,
        Steve Muckle <steve.muckle@linaro.org>,
        Olav Haugan <ohaugan@codeaurora.org>,
        Syed Rameez Mustafa <rameezmustafa@codeaurora.org>,
        Joonwoo Park <joonwoop@codeaurora.org>,
        Pavankumar Kondeti <pkondeti@codeaurora.org>,
        Saravana Kannan <skannan@codeaurora.org>,
        Bryan Huntsman <bryanh@codeaurora.org>,
        Juri Lelli <juri.lelli@arm.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Chris Redpath <chris.redpath@arm.com>,
        Robin Randhawa <robin.randhawa@arm.com>,
        Patrick Bellasi <patrick.bellasi@arm.com>,
        Todd Kjos <tkjos@google.com>, Srinath Sridharan <srinathsr@google.com>,
        Andres Oportus <andresoportus@google.com>,
        Leo Yan <leo.yan@linaro.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Vikram Mulukutla <markivx@codeauorora.org>
Subject: Re: [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization
 Tracking
In-Reply-To: <20161028074329.GS3102@twins.programming.kicks-ass.net>
References: <1477638642-17428-1-git-send-email-markivx@codeaurora.org>
 <1477638642-17428-3-git-send-email-markivx@codeaurora.org>
 <20161028074329.GS3102@twins.programming.kicks-ass.net>
Message-ID: <ff75fd471f98af81de4e8b9067d131c9@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 672
Lines: 24

On 2016-10-28 00:43, Peter Zijlstra wrote:
> On Fri, Oct 28, 2016 at 12:10:41AM -0700, Vikram Mulukutla wrote:
>> +u64 walt_ktime_clock(void)
>> +{
>> +	if (unlikely(walt_ktime_suspended))
>> +		return ktime_to_ns(ktime_last);
>> +	return ktime_get_ns();
>> +}
> 
>> +static int walt_suspend(void)
>> +{
>> +	ktime_last = ktime_get();
>> +	walt_ktime_suspended = true;
>> +	return 0;
>> +}
> 
> No, ktime_get() will not be used in the scheduler. Imagine the joy if
> that thing ends up being the HPET.

Agreed, this is an artifact from the full implementation that feeds into 
the
interactive governor, and thus both needed to use the same time source. 
It
shall go away.