Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757758AbcJ1ID5 (ORCPT ); Fri, 28 Oct 2016 04:03:57 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:46220 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756208AbcJ1ID2 (ORCPT ); Fri, 28 Oct 2016 04:03:28 -0400 Date: Fri, 28 Oct 2016 10:03:24 +0200 From: Sebastian Andrzej Siewior To: "Charles (Chas) Williams" Cc: linux-kernel@vger.kernel.org, rt@linutronix.de Subject: Re: [PREEMPT-RT] Oops in rapl_cpu_prepare() Message-ID: <20161028080324.b6nnwaljmzxiyykx@linutronix.de> References: <20161021105630.y2iym7smtdpyo54z@linutronix.de> <4e56a576-1a9f-e195-5ed9-2bc7169c4d94@brocade.com> <20161025122205.cw5xyejcg7xegnmq@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1361 Lines: 31 On 2016-10-27 15:00:32 [-0400], Charles (Chas) Williams wrote: > > I assume "init_rapl_pmus: maxpkg 4" is from init_rapl_pmus() returning > > topology_max_packages(). So it says 4 but then returns 65535 for CPU 2 > > and 3. That -1 comes probably from topology_update_package_map(). Could > > you please send a complete boot log and try the following patch? This > > one should fix your boot problem and disable RAPL if the info is > > invalid. > > But sometimes the topology info is correct and if I get lucky, the > package id could be valid for all the CPU's. Given the behavior, > I have seen so far it makes me thing the RAPL isn't being emulated. > So even if I did boot onto a "valid" set of cores, would I always be > certain that I will be on those cores? I don't what vmware does here. Nor do they ship source to check. So if you have a big HW box with say two packages, it might make sense to give this information to the guest _if_ the CPUs are pinned and the guest never migrates. > Per your request in your next email: > > > One thing I forgot to ask: Could you please check if you get the same > > pkgid reported for cpu 0-3 on a pre-v4.8 kernel? (before the hotplug > > rework). > > Our previous kernel was 4.4, and didn't use the logical package id: I see. Did the patch I sent fixed it for you and were you not able to test? Sebastian