Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757944AbcJ1Ikm (ORCPT ); Fri, 28 Oct 2016 04:40:42 -0400 Received: from mout.web.de ([212.227.15.3]:63889 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756194AbcJ1Iki (ORCPT ); Fri, 28 Oct 2016 04:40:38 -0400 Subject: [PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline() To: linux-kbuild@vger.kernel.org, Michal Marek References: <72e07814-56e9-505a-d660-91ff20b6efea@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Fri, 28 Oct 2016 10:40:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <72e07814-56e9-505a-d660-91ff20b6efea@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3iJIX8Yn/wtlN8tHg2i97ObXWYrnf4byWtqlrKonUJzi5s45SWM nwqRXUF+DIP6qveD+UDaGyTEQ6Eqe1BZD41VYKMaBpYCoIly5wK0uuPHu0KOoY3MxCrs2xJ iXCgxoZqa4i0lKpEVXxG0yCXB5/vGw0XjVleC7DQWoZCq2pJx0LfR6CwVwIB64W7XOps9eS /O/NkWU76zIVHcBU/h22w== X-UI-Out-Filterresults: notjunk:1;V01:K0:rOw7CgdJmI4=:DQ1k4BoRLMpuSW5AdNUJ7G Abf5jyf6ob0xpuco/YKFMkgfLgNqmsFxxsoguyZFyyolG1mKoFJ/N1WDKcaOk82w1BSt1fJ1i VqtGXQ5eDock0Q7kQprPFLyGd8lX3XfC8sfifRtkxcVssmCOORJAgvnRlrSQnW9Vf5JbWnNu4 xgtqfpB/pufCrShLOmNue5SfzGx6kJmJnfDa8LV7csG3BmbCSZYrTV+cn9ocZD3iT5vNZtCS4 Hifgk2D7OgsbT52wA2Iamcq26HmYKdghJ14MIRlW0iLeBQFGOfE9JGu2lbsJiFqbffnF6b1vJ 258ONDv1130yaNP5Y0Wc+OuGiidqTo+c3kMx0+X+p31w3ITzgCQaW4mE8pR+z8D18k6psTE/a HL+2hCsPEl7MESCeslkGE0ZGx+8pJDrjOR5RJEuT87H7aplRvNF36tUJuR43CR0ZEeZVeq3Th dcA3ZyuZOoIgp9/pLgskbnbnYcWmuR/vW0/HENovcbxCqv/TZuoLUSNe6RmXtutR9LEEvuVHl IFHav4jECKDMPWt/se28n5NcmJENmkPrFIGf9ecd0Y4A/4x9geKidaDZa63aLB0iC7XtwZ7Wx hVed8gT/lR0ywRdRHVT9BgFXj4ssL4M3qkqJh0Z1R2Fa0+zLjLq9kO4iQCwnADAx3rLrdII5O cMXQN+TrM7Dh+eoDYSxU25vUXlN8nf1vEEk1pOPpy57bEXF0OuCK9JNeH3dBbQaoRDhIh49V1 7CHzHDbcxSrXeYYtiaNgNdC9RJURuIs0o4xA4sLWZ4uWv+6eooyCgS3kZP07dJi77kZNXFvwS iCZDzLm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 857 Lines: 35 From: Markus Elfring Date: Fri, 28 Oct 2016 09:29:59 +0200 A return value was not checked from a call of the function "printf". This issue was detected also by using the Coccinelle software. Add a bit of exception handling there. Signed-off-by: Markus Elfring --- scripts/basic/fixdep.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c index f5ff6eea..911347a 100644 --- a/scripts/basic/fixdep.c +++ b/scripts/basic/fixdep.c @@ -132,7 +132,12 @@ static void usage(void) */ static void print_cmdline(void) { - printf("cmd_%s := %s\n\n", target, cmdline); + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { + int code = errno; + + perror("fixdep: print_cmdline"); + exit(code); + } } /* -- 2.10.1