Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759626AbcJ1ImU (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Oct 2016 04:42:20 -0400
Received: from mout.web.de ([212.227.15.4]:64245 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755836AbcJ1ImQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Oct 2016 04:42:16 -0400
Subject: [PATCH 10/10] scripts/basic/fixdep: Combine two fprintf() calls into
 one fputs() call in usage()
To: linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.com>
References: <72e07814-56e9-505a-d660-91ff20b6efea@users.sourceforge.net>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <e4ad7dc2-eeba-1389-369d-ae4ded67688e@users.sourceforge.net>
Date: Fri, 28 Oct 2016 10:41:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <72e07814-56e9-505a-d660-91ff20b6efea@users.sourceforge.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:52zA34Pmb41gLhioCOCdPBdyptMTblL40h5Lda5gPtKeR4UIcdT
 3K+h3BVpi8WIJpbxDFfbPBJU1TOTnxRzWPi4ee6WzPrTJALtf16Q7gFrFRBwwj4NliovpMT
 mpSrYC2NrL8Hyy+uB2hya7Ds9dzPncssRegNX2ATV9ZfRV57c5n9MKFTCqb3x9j3sjfbUNg
 lgrPsqx7WoBrC+P9i0r2Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Gx27Gp0zY+8=:34P5AMhvVfzPZIcT58o1Yo
 CGw2uo8h/QsxhjPq946tA61xw4xZXOycnn/eJ2taAoo2fpTwKXuqIJR8YgCfJC1ws1qEkfetj
 h/G1QTeraQht6jGprcyf95/tVstlMDM9bT8K8nxUMq6VGFu6v9g8ve+Q6kWpL5EpWgEU+Y/TX
 tR6UNt1Lksb1zP2fm4fp4/PgVgfc/OGQWIkYB1224/WHSkwxW2Fdun0w/Cl1PMSMVIst2Ba57
 6MgNJhS1TE7W9yZd3clfMxp5M8Ms7ylGmsuiMS1SX3qYnBQAQn/PkpjhZw+o/C4tkR5MD5ktf
 A3Ljb0P2kt7rmeG5vT075ZyHUpVNApV1UcNrQ5SFnHQM8ptNxQ90X7jioe5pBOsFt5tlzyMpY
 f8NzcagwQbN3YR+1mVfkWkYqOFEbCSBmzv3cNXp+cunYCtQjhwR6Rwx1jMaJX/3RkZvbDJPky
 csR3HbSkcLjOGsFTfn7o9OOyVYBptCzS2yKN1MX3HRsxbU4BXdvg2UUplQYQOVzhXdpbpOWly
 BR1VGcelLt8xOioIRYa+ETMjGETGuSr0u/y2rQ6D1wtarTKd5rQC6fK/GA3qmT5/IBlAuLl6f
 RIzzNU9ZI9CCTib/3Kpuvwp13bg4y1Ff/qFlRRd91BVKDNiswN7QuTOI4Ta2lNbpvgUBZKDFa
 dP4W46pFPZdmgbMWjKoUcrTMKBAHmx0PN10iGUFmF1f150et1FIOstuFuScPNBmrmBAsxCYAJ
 JOJ7+sLDCKIDJAvB2IAJPVZ/kllSjHNji+Rx359p2hT6IthwV41y41UN7n7B7gv1v/0qONF6Q
 yr6pNDV
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 983
Lines: 32

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 28 Oct 2016 09:45:30 +0200

Some data were printed by two separate function calls.
Print the same data by a single call of the function "fputs" instead.

This issue was detected also by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 scripts/basic/fixdep.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
index 911347a..bdd031f 100644
--- a/scripts/basic/fixdep.c
+++ b/scripts/basic/fixdep.c
@@ -122,8 +122,10 @@ char *cmdline;
 
 static void usage(void)
 {
-	fprintf(stderr, "Usage: fixdep [-e] <depfile> <target> <cmdline>\n");
-	fprintf(stderr, " -e  insert extra dependencies given on stdin\n");
+	if (fputs("Usage: fixdep [-e] <depfile> <target> <cmdline>\n"
+		  " -e  insert extra dependencies given on stdin\n", stderr)
+	   < 0)
+		perror("fixdep: usage");
 	exit(1);
 }
 
-- 
2.10.1