Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S941943AbcJ1Itz (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Oct 2016 04:49:55 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:51724 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750878AbcJ1Itv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Oct 2016 04:49:51 -0400
Date: Fri, 28 Oct 2016 10:49:45 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Vikram Mulukutla <markivx@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Srivatsa Vaddagiri <vatsa@codeaurora.org>,
        Steve Muckle <steve.muckle@linaro.org>,
        Olav Haugan <ohaugan@codeaurora.org>,
        Syed Rameez Mustafa <rameezmustafa@codeaurora.org>,
        Joonwoo Park <joonwoop@codeaurora.org>,
        Pavankumar Kondeti <pkondeti@codeaurora.org>,
        Saravana Kannan <skannan@codeaurora.org>,
        Bryan Huntsman <bryanh@codeaurora.org>,
        Juri Lelli <juri.lelli@arm.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Chris Redpath <chris.redpath@arm.com>,
        Robin Randhawa <robin.randhawa@arm.com>,
        Patrick Bellasi <patrick.bellasi@arm.com>,
        Todd Kjos <tkjos@google.com>, Srinath Sridharan <srinathsr@google.com>,
        Andres Oportus <andresoportus@google.com>,
        Leo Yan <leo.yan@linaro.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Vikram Mulukutla <markivx@codeauorora.org>
Subject: Re: [RFC PATCH 0/3] sched: Introduce Window Assisted Load Tracking
Message-ID: <20161028084945.GX3102@twins.programming.kicks-ass.net>
References: <1477638642-17428-1-git-send-email-markivx@codeaurora.org>
 <20161028074953.GU3102@twins.programming.kicks-ass.net>
 <9ac6a40a330b82e424dc2f56ea7fd976@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9ac6a40a330b82e424dc2f56ea7fd976@codeaurora.org>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1197
Lines: 27

On Fri, Oct 28, 2016 at 12:57:05AM -0700, Vikram Mulukutla wrote:
> On 2016-10-28 00:49, Peter Zijlstra wrote:
> >On Fri, Oct 28, 2016 at 12:10:39AM -0700, Vikram Mulukutla wrote:
> >>This RFC patch has been tested on live X86 machines with the following
> >>sanity
> >>and benchmark results (thanks to Juri Lelli, Dietmar Eggeman, Patrick
> >>Bellasi
> >>for initial code reviews):
> >>
> >>(Tested on an Intel i7 2nd generation CPU, 8GB RAM, Nvidia GTX950Ti
> >>graphics,
> >>with the same frequency list as above. Running Ubuntu 16.04 on a v4.8.2
> >>baseline. WALT window size was 10ms. Only deltas above 3% are considered
> >>non-noise.Power measured with Intel RAPL counters)
> >
> >Was this comparison done using the use_walt_metric sysctl knob?
> 
> Yes, it was. You will want to see numbers against a pure 4.8.2 without any
> of the WALT code, correct?

Yep, because with the sysctl we still run all the accounting code. So
esp things like the hackbench run are meaningless (note that even the
CONFIG thing doesn't take out everything).

Also, I think it makes sense to always (also) compare against the
"performance" governor. That way you can see the drop in absolute
performance etc..