Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760475AbcJ1MVc (ORCPT ); Fri, 28 Oct 2016 08:21:32 -0400 Received: from mail.skyhub.de ([78.46.96.112]:41148 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753308AbcJ1MV2 (ORCPT ); Fri, 28 Oct 2016 08:21:28 -0400 Date: Fri, 28 Oct 2016 14:21:23 +0200 From: Borislav Petkov To: Paolo Bonzini Cc: "Luc, Piotr" , "kvm@vger.kernel.org" , "he.chen@linux.intel.com" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "x86@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , "Kang, Luwei" , "rkrcmar@redhat.com" Subject: Re: [PATCH] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS features to kvm guest Message-ID: <20161028122123.24i3synevehn6r3p@pd.tnic> References: <1477645960-6898-1-git-send-email-he.chen@linux.intel.com> <1477649272.17668.7.camel@intel.com> <5c00fdf0-a5a4-7a78-4ed8-8ae3ef710a68@redhat.com> <20161028110834.svzzs5hftg3bybiz@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 472 Lines: 21 On Fri, Oct 28, 2016 at 02:07:21PM +0200, Paolo Bonzini wrote: > cpuid_count_edx would be just > > static inline unsigned int cpuid_count_edx(unsigned op, unsigned count) > { > unsigned int eax, ebx, ecx, edx; > > cpuid_count(op, count, &eax, &ebx, &ecx, &edx); > > return edx; > } Even better. But shouldn't this be hiding unimplemented CPUID bits from the guest? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.